SpacetimeDB icon indicating copy to clipboard operation
SpacetimeDB copied to clipboard

Added 'override' keywords to functions and properties extending from …

Open hsreina opened this issue 1 year ago • 1 comments

What version of TypeScript are you targeting?

Since version 4.3 of TypeScript, override keyword has been introduced for properties or functions of classes extending from other classes.

Recent frameworks using Typescript might enforce the presence of the override keyword.

Of course implicit in projects can be disabled with the follow code. But I think it might be better to have it.

{
  "compilerOptions": {
    // ...
    "noImplicitOverride": true
  }
}

hsreina avatar Mar 13 '24 04:03 hsreina

I need to have a look how you run rust unit tests

hsreina avatar Mar 13 '24 04:03 hsreina

Hi @hsreina This is a long time coming, but this PR is actually no longer necessary. We've rewritten the TypeScript SDK to not use inheritance at all.

cloutiertyler avatar Feb 08 '25 19:02 cloutiertyler