SpacetimeDB icon indicating copy to clipboard operation
SpacetimeDB copied to clipboard

Published 20 hours ago • verified publisher icon clockworklabs

table_name: use Arc<str>

Open Centril opened this issue 1 year ago • 4 comments

Description of Changes

Switches most cases where a table / reducer name is stored to an Arc<str> rather than String.

API and ABI breaking changes

None

Expected complexity level and risk

1

Centril avatar Jan 28 '24 13:01 Centril

This isn't yet a clear win; so let's hold off on merging. We might want to consider one of:

  • https://crates.io/crates/flexstr
  • https://crates.io/crates/smol_str
  • https://crates.io/crates/arcstr

Centril avatar Jan 29 '24 08:01 Centril

Also, I think instead is the whole schema that should be under Arc/Rc

mamcx avatar Feb 13 '24 15:02 mamcx

Because now DbTable & MemTable both have pub head: Arc<Header> this PR can be closed, right?

mamcx avatar Mar 14 '24 15:03 mamcx

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 03 '25 18:05 CLAassistant