SpacetimeDB
SpacetimeDB copied to clipboard
`spacetime-install.ps1` installs Visual C++ Redistributable if needed
Add VCRuntime detection and installation. This runtime is mandatory.
Description of Changes
Update the Windows powershell script to install VCRuntime.
Expected complexity level and risk
Not complex. Download directly from Microsoft.
Testing
Tested on a clean Windows 10 machine.
Thank you for creating this! We'll try to get it reviewed!
@iso8859 Can you describe what wasn't working for you originally? What actually requires this runtime? (e.g. does the installation itself fail, does it fail to build a project?)
I ask because we tested on a fresh Windows 10 + Windows 11 with all updates installed, and didn't see any issues.
Hi,
This is what you get when you download the installer and run it manually on a fresh Windows 10 machine.
There is no message indicating that the installation has failed when using the powershell script.
In fact, I'm wondering whether it wouldn't be interesting to add an installation success test to the script.
Thank you! We reproduced the issue over here.
Since this is part of the main SpacetimeDB repo, we ask contributors to sign our Contributor License Agreement (CLA) before we merge their changes.
If you're willing to sign our CLA, could you send an email to [email protected] to get the process started?