SpacetimeDB
SpacetimeDB copied to clipboard
clockworklabs
Dedupe Spacetime ABI namespace in MSBuild
Description of Changes
Some MSBuild magic to dedupe and centralise the ABI string in C#. After this change you should only update it in 1 place instead of 3, hopefully preventing issues like #1311 from reappearing.
API and ABI breaking changes
If this is an API or ABI breaking change, please apply the corresponding GitHub label.
Expected complexity level and risk
2 - simple changes, but since it's MSBuild, there's always a risk I broke something.
How complicated do you think these changes are? Grade on a scale from 1 to 5, where 1 is a trivial change, and 5 is a deep-reaching and complex change.
This complexity rating applies not only to the complexity apparent in the diff, but also to its interactions with existing and future code.
If you answered more than a 2, explain what is complex about the PR, and what other components it interacts with in potentially concerning ways.
Testing
Describe any testing you've done, and any testing you'd like your reviewers to do, so that you're confident that all the changes work as expected!
- [x] Write a test you've completed here.
- [ ] Write a test you want a reviewer to do here, so they can check it off when they're satisfied.
Heh clearly I at least broke builds on Linux, even though it works fine on Windows. Marking as draft for now.
