rewrite-clj Fix #331: sexpr on tagged literal should be fully qualified

Jan 31 '25 15:01 borkdude

Hmmmm... Seems to break cljs tests... and also zprint and umschreiben-clj.

Jan 31 '25 17:01 lread

The test in umschreiben fails exactly because they depend on the unqualified symbol right now The CLJS tests might fail because clojure.core/read-string or cljs.core/read-string doesn't exist. Should we emit clojure.edn/read-string instead? 🤔

Jan 31 '25 18:01 borkdude

Kinda feels sort similar in spirit to #305? zprint had some problems with that one too https://github.com/kkinnear/zprint/issues/333

Jan 31 '25 19:01 lread

@borkdude, this isn't PR isn't solving any immediate problem for me, so I've not been inclined to look into it, nor think about it. Do you still think we should do something here?

Feb 12 '25 20:02 lread

Eventually yes, since emitting an qualified name can lead to bad behavior.

Feb 12 '25 20:02 borkdude

Ok, tx, have followed up in issue.

Feb 12 '25 21:02 lread

I've been really dragging me feet on this one, eh?

I'll likely give this a whirl again sometime soon to see if it will break zprint (I think kkinnear said he made some changes to rely less on sexpr).

Nov 02 '25 15:11 lread