kibit icon indicating copy to clipboard operation
kibit copied to clipboard

Update dependencies

Open bbakersmith opened this issue 9 years ago • 4 comments
trafficstars

to keep from pulling in clojure 1.6 just for kibit

bbakersmith avatar Feb 21 '16 18:02 bbakersmith

:+1:

BenjaminVanRyseghem avatar Feb 21 '16 18:02 BenjaminVanRyseghem

Thanks for this! Have you checked if there are any issues with the tools.cli update?

I'm pretty sure Kibit's version of Clojure won't be used unless you're running without a project.clj. I'm not sure if it's worth upgrading it at right now. There's no 1.7 or 1.8 features that we're using, and it makes it more likely in the future that compatibility may be broken accidentally. I'm happy to take PRs for things that use 1.7 and 1.8 features that give wins, but I'm not so keen on dropping backwards compatibility if there's no reason to.

What are your thoughts?

danielcompton avatar Feb 21 '16 19:02 danielcompton

Kibit's version of Clojure is definitely retrieved, whether or not it's used. If I delete Clojure 1.6.0 from my local .m2 and run lein kibit it outputs:

Retrieving org/clojure/clojure/1.6.0/clojure-1.6.0.pom from central
Retrieving org/clojure/clojure/1.6.0/clojure-1.6.0.jar from central

Locally this isn't a big deal, because once it's downloaded it isn't retrieved again. But our continuous integration testing environments are refreshed regularly, so every time Kibit runs it re-downloads Clojure 1.6 as above.

Since Kibit pulls in its own version of Clojure when it doesn't match the project version, how much would it affect backwards compatibility to upgrade the Clojure version? If a project were using 1.6 but Kibit used 1.8 wouldn't it just pull in 1.8 like it pulls in 1.6 for our projects?

The tools.cli release notes don't list any breaking changes. I installed this branch locally and ran it with the --reporter flag without issue.

bbakersmith avatar Feb 21 '16 20:02 bbakersmith

I tested this with a Clojure 1.7 project and it pulls in Clojure 1.8 for Kibit as expected.

bbakersmith avatar Feb 21 '16 22:02 bbakersmith