jingo icon indicating copy to clipboard operation
jingo copied to clipboard

Published 20 hours ago • verified publisher icon claudioc

Support emojis

Open shinzui opened this issue 8 years ago • 3 comments

Marked currently does not support emojis and they've had the related issue open for three years now. I suggest switching to another library such as markdown-it.

Marked does not appear to be well maintained based on the number of outstanding issues and pull requests so switching has other benefits.

shinzui avatar Dec 13 '16 15:12 shinzui

I will take a look into this, it's a good point.

I believe I'd need to support both of them for a while to be sure I am not breaking anything (I cannot obviously test that markdown-it would work without any issue with ALL the existing Jingo installations).

Thanks!

claudioc avatar Jan 08 '17 14:01 claudioc

Switching to markdown-it will break something because many fixes are "breaking fix". I think it is safer to do the switch in next major version of Jingo.

Also: https://softwareengineering.stackexchange.com/questions/368030/is-a-breaking-change-bug-fix-a-semver-patch-or-a-major

FranklinYu avatar Aug 01 '18 18:08 FranklinYu

@franklinyu that's what I am doing indeed :)

claudioc avatar Aug 04 '18 16:08 claudioc