react-sortable-hoc icon indicating copy to clipboard operation
react-sortable-hoc copied to clipboard

Support React v. 18

Open patrykboch opened this issue 3 years ago • 10 comments

Fixes https://github.com/clauderic/react-sortable-hoc/issues/838

patrykboch avatar Jun 02 '22 20:06 patrykboch

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f28d4ac3e508097fa2d5f3fb12594e10e72c5df7:

Sandbox Source
react-sortable-hoc-starter Configuration

codesandbox-ci[bot] avatar Jun 02 '22 20:06 codesandbox-ci[bot]

@clauderic please review

patrykboch avatar Jun 08 '22 08:06 patrykboch

yes please review

chrishawn avatar Jun 15 '22 17:06 chrishawn

@chrishawn I'm afraid it might never be introduced. The lib is considered deprecated and further enhancements won't be merged. Only security fixes. See @dnd/kit as an alternative.

Anyways migration to @dnd/kit is not obvious and it'd be perfect to have the support of React v18 here. The newest version of React does ensure backward compatibility.

I see that ReactDOM.findDOMnode, ReactDOM.render, etc. are in fact deprecated but it does not mean they neither work with the latest React nor the lib in question. So please, @clauderic consider this.

patrykboch avatar Jun 15 '22 20:06 patrykboch

Would also like to see this merged. We can also not migrate away currently to another package. So would really like to see 18 official supported here.

alexander-schranz avatar Jul 10 '22 13:07 alexander-schranz

@clauderic : Please support that. We are using this package on so many pages so it will be a huge effort to migrate. Since the methods are still there (only deprecated), I really hope that this will be merged. Thanks!!!

arneee avatar Jul 19 '22 18:07 arneee

Hello, thanks for your work. Any target date for this to be merged? Best regards

SergioArrighi avatar Sep 07 '22 21:09 SergioArrighi

@clauderic Is there any migration guide to dnd-kit?

marwin1991 avatar Sep 18 '22 20:09 marwin1991

Hello,

Any updates for when it will be released?

Thanks everyone for the work.

marco-adapttech avatar Nov 18 '22 17:11 marco-adapttech

Hi guys, merge it please.

Artexoid avatar Mar 01 '23 16:03 Artexoid