react-sortable-hoc icon indicating copy to clipboard operation
react-sortable-hoc copied to clipboard

HOC should extends PureComponent

Open Saket23 opened this issue 4 years ago • 1 comments

We faced a performance issue recently while using react-sortable-hoc. If we have a large list, such as 300 to 400, and whenever its parent re-renders all the child also re renders.

So raising the PR to change it to PureComponent to get the performance benefit. Though I am a bit worried about folks who are already using it and have not taken care of the cons of using PureComponent.

Saket23 avatar Jun 02 '21 06:06 Saket23

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 46c5b16508cfd61fbe4b0fa49a1e8f8301ba0763:

Sandbox Source
react-sortable-hoc-starter Configuration

codesandbox-ci[bot] avatar Jun 02 '21 06:06 codesandbox-ci[bot]