react-sortable-hoc icon indicating copy to clipboard operation
react-sortable-hoc copied to clipboard

added conditional prop to disable animation when dragging

Open yuri-scarbaci-lenio opened this issue 5 years ago • 2 comments

Same as https://github.com/clauderic/react-sortable-hoc/pull/482 but with latest code-base from master

As per the conversation in the previous PR disabling animation is especially useful if the the final user wants to handle it's own animation.

Even more useful when the ghost item is kept in the list.

This is strictly required for anyone that wants to use react-sortable-hoc to implement a custom tree-view component, where the animation between different nest levels results more problematic than useful.

In our specific case we want to only add borders between new positions instead of actually moving the objects.

While this may not be the most common use-case, I don't see a reason why not providing a flag to disable the translate, this will never require any more complexity, it will always be a simple toggle that kept everything else as is except for the on drag-over animation.

Probably the code could be improved to be debounced a little, to avoid invoking the animateNode() function so many times when the mouse didn't move at all (start drag, don't move mouse, check how many times the animateNode function is invoked...) or if not debounced, at the very least memoized?

yuri-scarbaci-lenio avatar Oct 19 '20 22:10 yuri-scarbaci-lenio

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bf7e64f02759a1ecb1189164ec818cdc2f91a096:

Sandbox Source
react-sortable-hoc-starter Configuration

codesandbox-ci[bot] avatar Oct 19 '20 22:10 codesandbox-ci[bot]

Will this PR/feature ever be merged?

jmangel avatar Jul 29 '22 20:07 jmangel