react-sortable-hoc icon indicating copy to clipboard operation
react-sortable-hoc copied to clipboard

Published 20 hours ago • verified publisher icon clauderic

add rtl support

Open PersianArt opened this issue 6 years ago • 4 comments

This PR adds a rtl support when direction is set to rtl. Only need set rtl props to SortableContainer: <SortableList items={this.state.items} axis='x' rtl onSortEnd={this.onSortEnd} /> or <SortableList items={this.state.items} axis='xy' rtl onSortEnd={this.onSortEnd} />

Thanks

PersianArt avatar Dec 25 '18 20:12 PersianArt

@clauderic can you review this PR pls?

felixmosh avatar Mar 26 '19 17:03 felixmosh

Hi @PersianArt, Your solution is great, will you be fixing the minor conflict to complete the merge?

roeycohen avatar Dec 27 '20 11:12 roeycohen

@roeycohen , you can check mine PR https://github.com/clauderic/react-sortable-hoc/pull/518 which is based on this with fixes.

felixmosh avatar Dec 27 '20 13:12 felixmosh

Hi @PersianArt, Your solution is great, will you be fixing the minor conflict to complete the merge?

Hi, Unfortunately, the author of this package didn't consider this pr then there is no reason to solve new conflicts, but you can use my fork here: https://www.npmjs.com/package/react-sortable-hoc-rtl

Goodluck

PersianArt avatar Dec 27 '20 16:12 PersianArt