kamaji icon indicating copy to clipboard operation
kamaji copied to clipboard

Set the kamaji-etcd helm chart as dependancy of the kamaji chart

Open bsctl opened this issue 2 years ago • 4 comments

Currently, the kamaji Helm Chart is optionally installing its own datastore based on etcd. At same time, we developed the kamaji-etcd Helm Chart to provide a multi-tenant datastore for Kamaji based on etcd . To avoid duplication in maintenance of the charts, it would be useful to remove the native etcd datastore option in Kamaji Helm Chart and use the kamaji-etcd instead as dependancy sub-chart.

bsctl avatar Jan 05 '23 10:01 bsctl

This would be really useful. I just got confused by this trying Kamaji for the first time. The helm chart is also more configurable than the kamaji chart installation. For example I cannot add annotations to the serviceAccount for etcd in the kamaji chart.

Edit: It's even worse. The ETCD statefulset is hard-coded to use default serviceAccount.

jwitko avatar Jan 05 '24 17:01 jwitko

The ETCD statefulset is hard-coded to use default serviceAccount

Although this should be discussed in the kamaji-etcd chart, there's a rationale behind that, mostly related to the fact etcd is not expecting to interact with the Kubernetes API Server: the actions performed there, such as backups, are triggere with a temporary ServiceAccount deployed thanks to Helm hooks (source).

prometherion avatar Jan 22 '24 13:01 prometherion

@MathiasPius I remember your efforts in the Kamaji Etcd chart, wondering if you could help us with this task

prometherion avatar May 18 '24 16:05 prometherion

@prometherion I appreciate the opportunity, but I'm afraid I don't have very much insight into how Kamaji uses etcd under the hood, nor exactly how helm sub charts function, so I'd be very worried about causing loss of data for existing users of the charts.

I think the task is best left to someone else :)

MathiasPius avatar May 21 '24 20:05 MathiasPius