vscode-clangd icon indicating copy to clipboard operation
vscode-clangd copied to clipboard

Add an option to stop showing warning about clangd + mscpp incompatibility

Open kirillbobyrev opened this issue 4 years ago • 6 comments

Context: https://github.com/clangd/vscode-clangd/pull/141#issuecomment-784561701

kirillbobyrev avatar Mar 05 '21 07:03 kirillbobyrev

Maybe this shouldn't be a visible option, just a way to "never ask again"

sam-mccall avatar Mar 05 '21 11:03 sam-mccall

Yes, in my mind it looks like a button next to "Disable mscpp" on the warning.

On Fri, Mar 5, 2021, 2:09 PM Sam McCall [email protected] wrote:

Maybe this shouldn't be a visible option, just a way to "never ask again"

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/clangd/vscode-clangd/issues/162#issuecomment-791351315, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAZSTCC6UKQHJDRBF3HNTJDTCC3XVANCNFSM4YUWPCQA .

kirillbobyrev avatar Mar 05 '21 11:03 kirillbobyrev

I agree with the above here. Our project was setting

    "C_Cpp.autocomplete": "Disabled",  // So you don't get autocomplete from both extensions.
    "C_Cpp.errorSquiggles": "Disabled", // So you don't get error squiggles from both extensions

As clang's errors/autocomplete were much better, but leaving the intellisenseEngine enabled for the enhanced colorization

So an option to disable the warning would be great.

theswordsmahin avatar Mar 12 '21 01:03 theswordsmahin

I'm not very familiar with vscode-clangd's contribution process, but I also faced the same issue, so I have made a small patch adding a config option to disable this warning (https://github.com/matms/vscode-clangd/commit/95e90f77bc447f06959174b834dc06657ab34680).

I'm not sure if I should make a pull request?

matms avatar Aug 15 '21 21:08 matms

I'm not sure if I should make a pull request?

I would say yes, go ahead

HighCommander4 avatar Aug 15 '21 23:08 HighCommander4

I'm not very familiar with vscode-clangd's contribution process, but I also faced the same issue, so I have made a small patch adding a config option to disable this warning (matms@95e90f7).

I'm not sure if I should make a pull request?

Absolutely!

Sorry, this is actually my bad for forgetting about this and not delivering on my promise to fix this originally. I'll gladly review your patch and provide help if needed.

kirillbobyrev avatar Aug 16 '21 08:08 kirillbobyrev

Seems to be fixed, makes sense to close.

kirillbobyrev avatar May 26 '23 04:05 kirillbobyrev

The new GitHub UI makes me miss the button every time 😆 Thanks, @HighCommander4!

kirillbobyrev avatar May 26 '23 18:05 kirillbobyrev