clangd
clangd copied to clipboard
clangd
Clangd fails to parse SYCL headers
Clangd (built from the current Intel SYCL LLVM branch, apologies if it's behind) appears to be calling into Sema slightly differently to how the compiler does it normally; the instant I add -fsycl to the compilation flags and include the SYCL headers, clangd starts crashing in the guts of an AST traversal.
A one-line C++ file appears to trigger the problem (most of the time) if -fsycl is passed on the command line:
#include <CL/sycl.hpp>
Out of curiosity, is there any documentation around on how to start debugging these kinds of crashes? I'd be happy to dig into them more before reporting, but I'm not quite even managing to get a SourceLocation to turn into an actual file + line number yet.
Logs
I[15:17:09.828] clangd version 15.0.0 (https://github.com/intel/llvm.git a37ca8403341511c789f3e07768755a72befcd13)
I[15:17:09.828] Features: linux+debug
I[15:17:09.828] PID: 10777
I[15:17:09.828] Working directory: /localData/justinw/sycl
I[15:17:09.829] argv[0]: /localData/justinw/llvm-project/build/bin/clangd
I[15:17:09.829] argv[1]: --check=/localData/justinw/sycl/test.cpp
I[15:17:09.829] Entering check mode (no LSP server)
I[15:17:09.829] Testing on source file /localData/justinw/sycl/test.cpp
I[15:17:09.829] Loading compilation database...
I[15:17:09.866] Loaded compilation database from /localData/justinw/sycl/compile_commands.json
I[15:17:09.870] Compile command from CDB is: /localData/justinw/llvm-sycl/bin/clang++ --driver-mode=g++ -isystem /localData/justinw/llvm-sycl//include --gcc-toolchain=/d/sw/gcc/9.2.0/ --cuda-path=/d/sw/cuda/11.3.1/cuda-toolkit/ -std=c++17 -o /localData/justinw/sycl/test.o -c -fsycl --gcc-toolchain=/d/sw/gcc/9.2.0/ -resource-dir=/localData/justinw/llvm-project/build/lib/clang/15.0.0 -- /localData/justinw/sycl/test.cpp
I[15:17:09.870] Parsing command...
I[15:17:09.891] internal (cc1) args are: -cc1 -triple spir64-unknown-unknown -aux-triple x86_64-unknown-linux-gnu -fsycl-is-device -fdeclare-spirv-builtins -mllvm -sycl-opt -fenable-sycl-dae -Wno-sycl-strict -fsycl-int-header=/localData/000scratch/test-header-b4f8fa.h -fsycl-int-footer=/localData/000scratch/test-footer-0207df.h -sycl-std=2020 -fsycl-unique-prefix=0e1a0935590ef1ad -Wspir-compat -fsyntax-only -disable-free -clear-ast-before-backend -main-file-name test.cpp -mrelocation-model static -mframe-pointer=all -fmath-errno -ffp-contract=on -fno-rounding-math -fno-verbose-asm -mconstructor-aliases -aux-target-cpu x86-64 -mllvm -treat-scalable-fixed-error-as-warning -debugger-tuning=gdb -resource-dir /localData/justinw/llvm-project/build/lib/clang/15.0.0 -internal-isystem /localData/justinw/llvm-sycl/bin/../include/sycl -internal-isystem /localData/justinw/llvm-sycl/bin/../include -isystem /localData/justinw/llvm-sycl//include -I/d/sw/intel/latest/compilers_and_libraries_2020.0.166/linux/mkl/include -I/d/sw/openmpi/1.6.5/include -I/d/sw/dugio/latest/include -I/d/sw/fftw/3.2.2/include -c-isystem /intel_bug -internal-isystem /d/sw/gcc/9.2.0/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../include/c++/9.2.0 -internal-isystem /d/sw/gcc/9.2.0/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../include/c++/9.2.0/x86_64-pc-linux-gnu -internal-isystem /d/sw/gcc/9.2.0/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../include/c++/9.2.0/backward -internal-isystem /d/sw/gcc/9.2.0/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../include/c++/9.2.0 -internal-isystem /d/sw/gcc/9.2.0/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../include/c++/9.2.0/x86_64-pc-linux-gnu -internal-isystem /d/sw/gcc/9.2.0/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../include/c++/9.2.0/backward -internal-isystem /localData/justinw/llvm-project/build/lib/clang/15.0.0/include -internal-isystem /usr/local/include -internal-isystem /d/sw/gcc/9.2.0/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/include -internal-externc-isystem /include -internal-externc-isystem /usr/include -internal-isystem /localData/justinw/llvm-project/build/lib/clang/15.0.0/include -internal-isystem /usr/local/include -internal-isystem /d/sw/gcc/9.2.0/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/include -internal-externc-isystem /include -internal-externc-isystem /usr/include -std=c++17 -fdeprecated-macro -fdebug-compilation-dir=/localData/justinw/sycl -ferror-limit 19 -fmessage-length=230 -fgnuc-version=4.2.1 -fcxx-exceptions -fexceptions -faddrsig -D__GCC_HAVE_DWARF2_CFI_ASM=1 -x c++ /localData/justinw/sycl/test.cpp
I[15:17:09.892] Building preamble...
I[15:17:34.123] Indexing headers...
I[15:17:39.842] Building AST...
clangd: /localData/justinw/llvm-project/clang/include/clang/AST/Type.h:691: const clang::ExtQualsTypeCommonBase* clang::QualType::getCommonPtr() const: Assertion `!isNull() && "Cannot retrieve a NULL type pointer"' failed.
Stack trace from GDB:
#0 0x00007ffff66e8337 in raise () from /lib64/libc.so.6
#1 0x00007ffff66e9a28 in abort () from /lib64/libc.so.6
#2 0x00007ffff66e1156 in __assert_fail_base () from /lib64/libc.so.6
#3 0x00007ffff66e1202 in __assert_fail () from /lib64/libc.so.6
#4 0x00000000004170c8 in clang::QualType::getCommonPtr (this=0x7fffffff31f8) at /localData/justinw/llvm-project/clang/include/clang/AST/Type.h:691
#5 0x000000000041853c in clang::QualType::getTypePtr (this=0x7fffffff31f8) at /localData/justinw/llvm-project/clang/include/clang/AST/Type.h:6503
#6 0x00000000004171ca in clang::QualType::operator-> (this=0x7fffffff31f8) at /localData/justinw/llvm-project/clang/include/clang/AST/Type.h:733
#7 0x0000000000cb6317 in clang::DecltypeType::DecltypeType (this=0xc16b3e0, E=0xc16b3b8, underlyingType=..., can=...) at /localData/justinw/llvm-project/clang/lib/AST/Type.cpp:3483
#8 0x0000000000cb6483 in clang::DependentDecltypeType::DependentDecltypeType (this=0xc16b3e0, Context=..., E=0xc16b3b8) at /localData/justinw/llvm-project/clang/lib/AST/Type.cpp:3497
#9 0x00000000008458fb in clang::ASTContext::getDecltypeType (this=0x98e5ce0, e=0xc16b3b8, UnderlyingType=...) at /localData/justinw/llvm-project/clang/lib/AST/ASTContext.cpp:5632
#10 0x0000000002b83792 in clang::serialization::AbstractTypeReader<clang::ASTRecordReader>::readDecltypeType (this=0x7fffffff3430) at tools/clang/include/clang/AST/AbstractTypeReader.inc:292
#11 0x0000000002b6bdb8 in clang::serialization::AbstractTypeReader<clang::ASTRecordReader>::read (this=0x7fffffff3430, kind=clang::Type::Decltype) at tools/clang/include/clang/AST/AbstractTypeReader.inc:45
#12 0x0000000002b3f9bf in clang::ASTReader::readTypeRecord (this=0xe3f2550, Index=64601) at /localData/justinw/llvm-project/clang/lib/Serialization/ASTReader.cpp:6448
#13 0x0000000002b42e75 in clang::ASTReader::GetType (this=0xe3f2550, ID=519208) at /localData/justinw/llvm-project/clang/lib/Serialization/ASTReader.cpp:7105
#14 0x0000000002b42faf in clang::ASTReader::getLocalType (this=0xe3f2550, F=..., LocalID=519208) at /localData/justinw/llvm-project/clang/lib/Serialization/ASTReader.cpp:7119
#15 0x0000000002b0ca5b in clang::ASTReader::readType (this=0xe3f2550, F=..., Record=..., Idx=@0x7fffffff3a98: 18) at /localData/justinw/llvm-project/clang/include/clang/Serialization/ASTReader.h:1817
#16 0x0000000002b0d08e in clang::ASTRecordReader::readType (this=0x7fffffff3a80) at /localData/justinw/llvm-project/clang/include/clang/Serialization/ASTRecordReader.h:177
#17 0x0000000002b41221 in clang::ASTRecordReader::readTypeSourceInfo (this=0x7fffffff3a80) at /localData/justinw/llvm-project/clang/lib/Serialization/ASTReader.cpp:6822
#18 0x0000000002bcd1e0 in clang::ASTDeclReader::readTypeSourceInfo (this=0x7fffffff3a30) at /localData/justinw/llvm-project/clang/lib/Serialization/ASTReaderDecl.cpp:123
#19 0x0000000002bce256 in clang::ASTDeclReader::VisitTypedefNameDecl (this=0x7fffffff3a30, TD=0xc16b2e0) at /localData/justinw/llvm-project/clang/lib/Serialization/ASTReaderDecl.cpp:679
#20 0x0000000002bce347 in clang::ASTDeclReader::VisitTypeAliasDecl (this=0x7fffffff3a30, TD=0xc16b2e0) at /localData/justinw/llvm-project/clang/lib/Serialization/ASTReaderDecl.cpp:699
#21 0x0000000002bfc6ac in clang::declvisitor::Base<std::add_pointer, clang::ASTDeclReader, void>::Visit (this=0x7fffffff3a30, D=0xc16b2e0) at tools/clang/include/clang/AST/DeclNodes.inc:329
#22 0x0000000002bcd802 in clang::ASTDeclReader::Visit (this=0x7fffffff3a30, D=0xc16b2e0) at /localData/justinw/llvm-project/clang/lib/Serialization/ASTReaderDecl.cpp:528
#23 0x0000000002bf8c1a in clang::ASTReader::ReadDeclRecord (this=0xe3f2550, ID=80954) at /localData/justinw/llvm-project/clang/lib/Serialization/ASTReaderDecl.cpp:3785
#24 0x0000000002b444fc in clang::ASTReader::GetDecl (this=0xe3f2550, ID=80954) at /localData/justinw/llvm-project/clang/lib/Serialization/ASTReader.cpp:7477
#25 0x0000000002b0ca9b in clang::ASTReader::GetLocalDecl (this=0xe3f2550, F=..., LocalID=80954) at /localData/justinw/llvm-project/clang/include/clang/Serialization/ASTReader.h:1850
#26 0x0000000002b44958 in <lambda(clang::ASTReader::ModuleFile*, clang::ASTReader::LexicalContents)>::operator()(clang::ASTReader::ModuleFile *, clang::ASTReader::LexicalContents) const (__closure=0x7fffffff3fc0, M=0x95872a0,
LexicalDecls=...) at /localData/justinw/llvm-project/clang/lib/Serialization/ASTReader.cpp:7557
#27 0x0000000002b44bda in clang::ASTReader::FindExternalLexicalDecls(clang::DeclContext const*, llvm::function_ref<bool (clang::Decl::Kind)>, llvm::SmallVectorImpl<clang::Decl*>&) (this=0xe3f2550, DC=0xc168af8, IsKindWeWant=...,
Decls=...) at /localData/justinw/llvm-project/clang/lib/Serialization/ASTReader.cpp:7571
#28 0x000000000097b4f2 in clang::ExternalASTSource::FindExternalLexicalDecls (this=0xe3f2568, DC=0xc168af8, Result=...) at /localData/justinw/llvm-project/clang/include/clang/AST/ExternalASTSource.h:185
#29 0x000000000098499f in clang::DeclContext::LoadLexicalDeclsFromExternalStorage (this=0xc168af8) at /localData/justinw/llvm-project/clang/lib/AST/DeclBase.cpp:1377
#30 0x0000000000984bc4 in clang::DeclContext::decls_begin (this=0xc168af8) at /localData/justinw/llvm-project/clang/lib/AST/DeclBase.cpp:1433
#31 0x0000000000418cf8 in clang::DeclContext::decls (this=0xc168af8) at /localData/justinw/llvm-project/clang/include/clang/AST/DeclBase.h:2127
#32 0x0000000001d14e99 in clang::RecursiveASTVisitor<clang::CallGraph>::TraverseDeclContextHelper (this=0x7fffffff4b90, DC=0xc168af8) at /localData/justinw/llvm-project/clang/include/clang/AST/RecursiveASTVisitor.h:1416
#33 0x0000000001d0e510 in clang::RecursiveASTVisitor<clang::CallGraph>::TraverseCXXRecordDecl (this=0x7fffffff4b90, D=0xc168ab8) at /localData/justinw/llvm-project/clang/include/clang/AST/RecursiveASTVisitor.h:1943
#34 0x0000000001d08469 in clang::RecursiveASTVisitor<clang::CallGraph>::TraverseDecl (this=0x7fffffff4b90, D=0xc168ab8) at tools/clang/include/clang/AST/DeclNodes.inc:283
#35 0x0000000001d0d4b4 in clang::RecursiveASTVisitor<clang::CallGraph>::TraverseClassTemplateDecl (this=0x7fffffff4b90, D=0xc168980) at /localData/justinw/llvm-project/clang/include/clang/AST/RecursiveASTVisitor.h:1821
#36 0x0000000001d08304 in clang::RecursiveASTVisitor<clang::CallGraph>::TraverseDecl (this=0x7fffffff4b90, D=0xc168980) at tools/clang/include/clang/AST/DeclNodes.inc:227
#37 0x0000000001d14f2b in clang::RecursiveASTVisitor<clang::CallGraph>::TraverseDeclContextHelper (this=0x7fffffff4b90, DC=0xcc348f8) at /localData/justinw/llvm-project/clang/include/clang/AST/RecursiveASTVisitor.h:1418
#38 0x0000000001d0b7d1 in clang::RecursiveASTVisitor<clang::CallGraph>::TraverseNamespaceDecl (this=0x7fffffff4b90, D=0xcc348c8) at /localData/justinw/llvm-project/clang/include/clang/AST/RecursiveASTVisitor.h:1555
#39 0x0000000001d080a0 in clang::RecursiveASTVisitor<clang::CallGraph>::TraverseDecl (this=0x7fffffff4b90, D=0xcc348c8) at tools/clang/include/clang/AST/DeclNodes.inc:131
#40 0x0000000001d14f2b in clang::RecursiveASTVisitor<clang::CallGraph>::TraverseDeclContextHelper (this=0x7fffffff4b90, DC=0x9764158) at /localData/justinw/llvm-project/clang/include/clang/AST/RecursiveASTVisitor.h:1418
#41 0x0000000001d0b7d1 in clang::RecursiveASTVisitor<clang::CallGraph>::TraverseNamespaceDecl (this=0x7fffffff4b90, D=0x9764128) at /localData/justinw/llvm-project/clang/include/clang/AST/RecursiveASTVisitor.h:1555
#42 0x0000000001d080a0 in clang::RecursiveASTVisitor<clang::CallGraph>::TraverseDecl (this=0x7fffffff4b90, D=0x9764128) at tools/clang/include/clang/AST/DeclNodes.inc:131
#43 0x0000000001d14f2b in clang::RecursiveASTVisitor<clang::CallGraph>::TraverseDeclContextHelper (this=0x7fffffff4b90, DC=0x97641e8) at /localData/justinw/llvm-project/clang/include/clang/AST/RecursiveASTVisitor.h:1418
#44 0x0000000001d0b7d1 in clang::RecursiveASTVisitor<clang::CallGraph>::TraverseNamespaceDecl (this=0x7fffffff4b90, D=0x97641b8) at /localData/justinw/llvm-project/clang/include/clang/AST/RecursiveASTVisitor.h:1555
#45 0x0000000001d080a0 in clang::RecursiveASTVisitor<clang::CallGraph>::TraverseDecl (this=0x7fffffff4b90, D=0x97641b8) at tools/clang/include/clang/AST/DeclNodes.inc:131
#46 0x0000000001d14f2b in clang::RecursiveASTVisitor<clang::CallGraph>::TraverseDeclContextHelper (this=0x7fffffff4b90, DC=0xd9d23c0) at /localData/justinw/llvm-project/clang/include/clang/AST/RecursiveASTVisitor.h:1418
#47 0x0000000001d14277 in clang::RecursiveASTVisitor<clang::CallGraph>::TraverseTranslationUnitDecl (this=0x7fffffff4b90, D=0xd9d2398) at /localData/justinw/llvm-project/clang/include/clang/AST/RecursiveASTVisitor.h:1519
#48 0x0000000001d08dc6 in clang::RecursiveASTVisitor<clang::CallGraph>::TraverseDecl (this=0x7fffffff4b90, D=0xd9d2398) at tools/clang/include/clang/AST/DeclNodes.inc:621
#49 0x0000000001d068a3 in clang::CallGraph::addToCallGraph (this=0x7fffffff4b90, D=0xd9d2398) at /localData/justinw/llvm-project/clang/include/clang/Analysis/CallGraph.h:70
#50 0x0000000003857391 in DeviceFunctionTracker::DeviceFunctionTracker (this=0x7fffffff4b90, S=...) at /localData/justinw/llvm-project/clang/lib/Sema/SemaSYCL.cpp:737
#51 0x0000000003863d98 in clang::Sema::MarkDevices (this=0xcfb8df0) at /localData/justinw/llvm-project/clang/lib/Sema/SemaSYCL.cpp:3941
#52 0x0000000002d56ada in clang::Sema::ActOnEndOfTranslationUnitFragment (this=0xcfb8df0, Kind=clang::Sema::Normal) at /localData/justinw/llvm-project/clang/lib/Sema/Sema.cpp:1137
#53 0x0000000002d56d97 in clang::Sema::ActOnEndOfTranslationUnit (this=0xcfb8df0) at /localData/justinw/llvm-project/clang/lib/Sema/Sema.cpp:1173
#54 0x0000000002a10a86 in clang::Parser::ParseTopLevelDecl (this=0x9fa9e20, Result=..., ImportState=@0x7fffffff5ba4: clang::Sema::ModuleImportState::FirstDecl)
at /localData/justinw/llvm-project/clang/lib/Parse/Parser.cpp:701
#55 0x0000000002a1044b in clang::Parser::ParseFirstTopLevelDecl (this=0x9fa9e20, Result=..., ImportState=@0x7fffffff5ba4: clang::Sema::ModuleImportState::FirstDecl)
at /localData/justinw/llvm-project/clang/lib/Parse/Parser.cpp:591
#56 0x0000000002a08129 in clang::ParseAST (S=..., PrintStats=false, SkipFunctionBodies=false) at /localData/justinw/llvm-project/clang/lib/Parse/ParseAST.cpp:161
#57 0x0000000002825a15 in clang::ASTFrontendAction::ExecuteAction (this=0x9b8f380) at /localData/justinw/llvm-project/clang/lib/Frontend/FrontendAction.cpp:1083
#58 0x0000000002825345 in clang::FrontendAction::Execute (this=0x9b8f380) at /localData/justinw/llvm-project/clang/lib/Frontend/FrontendAction.cpp:976
#59 0x00000000015beb3a in clang::clangd::ParsedAST::build (Filename=..., Inputs=..., CI=std::unique_ptr<clang::CompilerInvocation> = {...}, CompilerInvocationDiags=..., Preamble=
std::shared_ptr<const clang::clangd::PreambleData> (use count 2, weak count 0) = {...}) at /localData/justinw/llvm-project/clang-tools-extra/clangd/ParsedAST.cpp:552
#60 0x000000000071bba9 in clang::clangd::(anonymous namespace)::Checker::buildAST (this=0x7fffffff8f00) at /localData/justinw/llvm-project/clang-tools-extra/clangd/tool/Check.cpp:177
#61 0x000000000071cc71 in clang::clangd::check(llvm::StringRef, llvm::function_ref<bool (clang::clangd::Position const&)>, clang::clangd::ThreadsafeFS const&, clang::clangd::ClangdLSPServer::Options const&, bool) (File=...,
ShouldCheckLine=..., TFS=..., Opts=..., EnableCodeCompletion=false) at /localData/justinw/llvm-project/clang-tools-extra/clangd/tool/Check.cpp:285
#62 0x00000000006e6924 in main (argc=2, argv=0x7fffffffb148) at /localData/justinw/llvm-project/clang-tools-extra/clangd/tool/ClangdMain.cpp:980
System information
Output of clangd --version:
clangd version 15.0.0 (https://github.com/intel/llvm.git a37ca8403341511c789f3e07768755a72befcd13)
Editor/LSP plugin:
N/A in this case (tested via --check=), but normally VS Code
Operating system: CentOS 7.7
Disclaimer: I'm totally unfamiliar with SYCL :-( I'm pretty sure nobody's tried this before. And we don't really have the bandwidth to properly support all the language variants that are in-tree (OpenCL, OpenMP etc) let alone building clangd with a modified clang parser.
Happy to give some pointers, but a warning: It took a while to smooth out many bumps/crashes in clangd's use of the clang parser, in a fork where this has been changed a lot and clangd hasn't been tested I'd expect it to need some work.
Some ideas:
- it's probably first worth minimizing the input. i.e. what's the minimum code you can reduce that header and its transitive includes to that will still crash.
- this is crashing inside some SYCL-specific traversal (
Sema::MarkDevices) that's been added to Sema as part of each parse. Are you sure this needs to run at all in clangd? - it seems to be running a RecursiveASTVisitor to traverse the whole translation unit. This is at minimum going to be unacceptably slow for interactive use, as it has to deserialize the whole preamble (a PCH/module built from the transitive includes). For clangd's own analyses we use RecursiveASTVisitor after calling ASTContext::setTraversalScope to limit the walk, but I suspect that hasn't been called yet here.
- the crash is happening in clang code, specifically AST deserialization code. Serialization/deserialization bugs could easily be lurking if SYCL involves changes to the AST and hasn't been thoroughly battle-tested through use with PCHes or modules.
- apart from serialization/PCH-related problems, I'd guess the next most significant difference is clangd's (serialized) ASTs for headers don't contain bodies of most functions for performance. This used to crash a lot when it was first added, and may be causing you problems.
I'm not quite even managing to get a SourceLocation to turn into an actual file + line number yet.
In general Loc.printToString(SM) should give you something useful, if it won't something's quite wrong. (Or you're deeply buried in macros, where things are just inherently confusing)
Disclaimer: I'm totally unfamiliar with SYCL :-( I'm pretty sure nobody's tried this before. And we don't really have the bandwidth to properly support all the language variants that are in-tree (OpenCL, OpenMP etc) let alone building clangd with a modified clang parser.
Happy to give some pointers, but a warning: It took a while to smooth out many bumps/crashes in clangd's use of the clang parser, in a fork where this has been changed a lot and clangd hasn't been tested I'd expect it to need some work.
No worries - I figured I'd be in for a bit of DIY poking around given the fairly bleeding-edge nature of the Intel LLVM branch at present. Probably doesn't help that I'm totally unfamiliar with LLVM internals :joy:
And I was just beginning to like how easily it was letting me build code for all the GPUs I have access to from the one source tree. Guess nothing in life comes easy.
Some ideas:
it's probably first worth minimizing the input. i.e. what's the minimum code you can reduce that header and its transitive includes to that will still crash.
Yeah, I started looking into it but the tangled weave of template dependencies was too much for my brain at 4pm. I'll start teasing it apart a little more.
this is crashing inside some SYCL-specific traversal (
Sema::MarkDevices) that's been added to Sema as part of each parse. Are you sure this needs to run at all in clangd?
Initially, I doubt it. I believe it parses kernel code more strictly for compilation (to disallow stuff like virtual function calls etc that don't make sense on GPUs), but for now I suppose - at least for my own immediate use - it'd be safe to disable that part and leave it as a TODO.
it seems to be running a RecursiveASTVisitor to traverse the whole translation unit. This is at minimum going to be unacceptably slow for interactive use, as it has to deserialize the whole preamble (a PCH/module built from the transitive includes). For clangd's own analyses we use RecursiveASTVisitor after calling ASTContext::setTraversalScope to limit the walk, but I suspect that hasn't been called yet here.
the crash is happening in clang code, specifically AST deserialization code. Serialization/deserialization bugs could easily be lurking if SYCL involves changes to the AST and hasn't been thoroughly battle-tested through use with PCHes or modules.
This seems likely, from my limited knowledge of how its compilation phase works.
apart from serialization/PCH-related problems, I'd guess the next most significant difference is clangd's (serialized) ASTs for headers don't contain bodies of most functions for performance. This used to crash a lot when it was first added, and may be causing you problems.
I'm not quite even managing to get a SourceLocation to turn into an actual file + line number yet.
In general Loc.printToString(SM) should give you something useful, if it won't something's quite wrong. (Or you're deeply buried in macros, where things are just inherently confusing)
Ah, yeah, I was probing around in the RecursiveASTVisitor and couldn't easily see how to get to a SourceManager from where I was at that level of the stack.
Cheers for the suggestions - I'll try and make some time to dive in and see what I can come up with.
Hey @jwake did you make any progress with this? I'm quite keen to get this feature working & wouldn't mind helping out, though I'm not that familiar myself.
Nothing meaningful - just giving myself a crash course in LLVM, so named because I'm mostly just crashing LLVM over and over.
I'm sure I remember clangd working with SYCL in the past, so I might start with a git bisect & see if I get anywhere.
After failing to find a good commit for my bisect, I remembered I previously just worked around this by messing with compile_commands.json or alternatively some vscode setting (I think?) to remove the -fsycl and just manually add the includes llvm/include/sycl/ and llvm/include. I'm not sure if this might limit clangd's functionality compared with -fsycl but it seems to work for what I need. I fear my approach wouldn't scale well to large CMake projects...
I'm working on a code-base that also contains a good amount of SYCL code, so I'll tag along here as well. Do you see the same kinds of failures with hipSYCL? I might give this a look, as I'm already working on clangd a bit.
There seems to no longer crash, but it still isn't able to find the sycl.hpp. Super boring because I love to use nvim and now I am domed to use vscode (what the hell are they using, isn't clangd ????) ...
[START][2024-01-25 16:13:20] LSP logging initiated
[ERROR][2024-01-25 16:13:20] .../vim/lsp/rpc.lua:734 "rpc" "/var/home/cerqueira/.local/share/nvim/mason/bin/clangd" "stderr" "The flag `-cross-file-rename` is obsolete and ignored.\nI[16:13:20.633] clangd version 17.0.3 (https://github.com/llvm/llvm-project 888437e1b60011b8a375dd30928ec925b448da57)\nI[16:13:20.633] Features: linux+grpc\nI[16:13:20.633] PID: 49564\nI[16:13:20.633] Working directory: /var/home/cerqueira/Faculdade/Thesis/Code/vector-add\nI[16:13:20.633] argv[0]: /var/home/cerqueira/.local/share/nvim/mason/bin/clangd\nI[16:13:20.633] argv[1]: --background-index\nI[16:13:20.633] argv[2]: --clang-tidy\nI[16:13:20.633] argv[3]: --completion-style=bundled\nI[16:13:20.633] argv[4]: --cross-file-rename\nI[16:13:20.633] argv[5]: --header-insertion=iwyu\nI[16:13:20.633] Starting LSP over stdin/stdout\nI[16:13:20.638] <-- initialize(1)\nI[16:13:20.638] --> reply:initialize(1) 0 ms\n"
[ERROR][2024-01-25 16:13:20] .../vim/lsp/rpc.lua:734 "rpc" "/var/home/cerqueira/.local/share/nvim/mason/bin/clangd" "stderr" "I[16:13:20.925] <-- initialized\nI[16:13:20.925] <-- textDocument/didOpen\n"
[ERROR][2024-01-25 16:13:20] .../vim/lsp/rpc.lua:734 "rpc" "/var/home/cerqueira/.local/share/nvim/mason/bin/clangd" "stderr" "I[16:13:20.926] Loaded compilation database from /var/home/cerqueira/Faculdade/Thesis/Code/vector-add/compile_commands.json\nI[16:13:20.927] ASTWorker building file /var/home/cerqueira/Faculdade/Thesis/Code/vector-add/src/vector-add.cpp version 0 with command \n[/home/cerqueira/Faculdade/Thesis/Code/vector-add/build]\n/opt/intel/oneapi/compiler/2024.0/bin/icpx -fsycl -Wall -o CMakeFiles/vector-add.dir/src/vector-add.cpp.o -c -resource-dir=/var/home/cerqueira/.local/share/nvim/mason/packages/clangd/clangd_17.0.3/lib/clang/17 -- /var/home/cerqueira/Faculdade/Thesis/Code/vector-add/src/vector-add.cpp\n"
[ERROR][2024-01-25 16:13:20] .../vim/lsp/rpc.lua:734 "rpc" "/var/home/cerqueira/.local/share/nvim/mason/bin/clangd" "stderr" "I[16:13:20.927] Loaded compilation database from /home/cerqueira/Faculdade/Thesis/Code/vector-add/compile_commands.json\n"
[ERROR][2024-01-25 16:13:20] .../vim/lsp/rpc.lua:734 "rpc" "/var/home/cerqueira/.local/share/nvim/mason/bin/clangd" "stderr" "I[16:13:20.946] <-- textDocument/semanticTokens/full(2)\n"
[ERROR][2024-01-25 16:13:21] .../vim/lsp/rpc.lua:734 "rpc" "/var/home/cerqueira/.local/share/nvim/mason/bin/clangd" "stderr" "I[16:13:21.282] Built preamble of size 3611584 for file /var/home/cerqueira/Faculdade/Thesis/Code/vector-add/src/vector-add.cpp version 0 in 0.35 seconds\n"
[ERROR][2024-01-25 16:13:21] .../vim/lsp/rpc.lua:734 "rpc" "/var/home/cerqueira/.local/share/nvim/mason/bin/clangd" "stderr" "I[16:13:21.282] --> workspace/semanticTokens/refresh(0)\nI[16:13:21.282] Indexing c++17 standard library in the context of /var/home/cerqueira/Faculdade/Thesis/Code/vector-add/src/vector-add.cpp\n"
[ERROR][2024-01-25 16:13:21] .../vim/lsp/rpc.lua:734 "rpc" "/var/home/cerqueira/.local/share/nvim/mason/bin/clangd" "stderr" "I[16:13:21.284] <-- $/cancelRequest\nI[16:13:21.284] <-- textDocument/semanticTokens/full(3)\nI[16:13:21.284] <-- reply(0)\n"
[ERROR][2024-01-25 16:13:21] .../vim/lsp/rpc.lua:734 "rpc" "/var/home/cerqueira/.local/share/nvim/mason/bin/clangd" "stderr" "E[16:13:21.322] IncludeCleaner: Failed to get an entry for resolved path : No such file or directory\n"
[ERROR][2024-01-25 16:13:21] .../vim/lsp/rpc.lua:734 "rpc" "/var/home/cerqueira/.local/share/nvim/mason/bin/clangd" "stderr" "I[16:13:21.325] --> textDocument/publishDiagnostics\nI[16:13:21.326] --> reply:textDocument/semanticTokens/full(2) 379 ms, error: Task was cancelled.\nI[16:13:21.326] --> reply:textDocument/semanticTokens/full(3) 42 ms\n"
[ERROR][2024-01-25 16:13:23] .../vim/lsp/rpc.lua:734 "rpc" "/var/home/cerqueira/.local/share/nvim/mason/bin/clangd" "stderr" "I[16:13:23.226] Indexed c++17 standard library (incomplete due to errors): 13659 symbols, 1916 filtered\n"
it still isn't able to find the
sycl.hpp
You may need to manually specify the include directory where this header is located.
now I am domed to use vscode (what the hell are they using, isn't clangd ????) ...
VSCode can use either clangd, or Microsoft's proprietary language server (vscode-cpptools). Not sure which one you were trying it with.
You may need to manually specify the include directory where this header is located.
I am using compile_command.json generated by cmake. I have tried adding -I location of the header but didn't work.
[
{
"directory": "/var/home/cerqueira/Faculdade/Thesis/Code/vector-add/build",
"command": "/opt/intel/oneapi/compiler/2024.0/bin/icpx -fsycl -Wall -I/opt/intel/oneapi/compiler/latest/include/ -o CMakeFiles/vector-add.dir/src/vector-add.cpp.o -c /var/home/cerqueira/Faculdade/Thesis/Code/vector-add/src/vector-add.cpp",
"file": "/var/home/cerqueira/Faculdade/Thesis/Code/vector-add/src/vector-add.cpp",
"output": "CMakeFiles/vector-add.dir/src/vector-add.cpp.o"
}
]
I have tried adding -I location of the header but didn't work.
Please share clangd logs for further investigation.
Had the same issue. I am compiling https://github.com/addy419/lats and have the oneapi compile installed with spack. Made the compile_commands.json file with bear -- make sycl-usm and ran clangd-14 --compile-commands-dir ./ --check=./sycl-usm.cpp. This clangd is from the apt repo, but since my compile_commands.json was using icpx, I was hoping it would work the same way as in the makefile. This is what I got instead.
I[00:39:37.463] Ubuntu clangd version 14.0.0-1ubuntu1.1
I[00:39:37.463] Features: linux+grpc
I[00:39:37.463] PID: 237756
I[00:39:37.463] Working directory: /home/zm23374/lats
I[00:39:37.463] argv[0]: clangd-14
I[00:39:37.463] argv[1]: --compile-commands-dir
I[00:39:37.463] argv[2]: ./
I[00:39:37.463] argv[3]: --check=./sycl-usm.cpp
I[00:39:37.463] Entering check mode (no LSP server)
I[00:39:37.463] Testing on source file /home/zm23374/lats/sycl-usm.cpp
I[00:39:37.463] Loading compilation database...
I[00:39:37.463] Loaded compilation database from /home/zm23374/lats/./compile_commands.json
I[00:39:37.463] Compile command from CDB is: /home/zm23374/Apps/spack/opt/spack/linux-ubuntu22.04-skylake/gcc-11.4.0/intel-oneapi-compilers-2023.2.1-xq4ylpocz5g63twqrwf4xqmymwuuam2v/compiler/2023.2.1/linux/bin/icpx -O3 -fsycl -DENABLE_PROFILING -c -I /home/zm23374/Apps/spack/opt/spack/linux-ubuntu22.04-skylake/gcc-11.4.0/intel-oneapi-compilers-2023.2.1-xq4ylpocz5g63twqrwf4xqmymwuuam2v/compiler/2023.2.1/linux/lib/oclfpga/include -o obj_sycl.o -resource-dir=/usr/lib/llvm-14/lib/clang/14.0.0 -- /home/zm23374/lats/sycl-usm.cpp
I[00:39:37.463] Parsing command...
I[00:39:37.464] internal (cc1) args are: -cc1 -triple x86_64-pc-linux-gnu -fsycl-is-device -sycl-std=2020 -fsyntax-only -disable-free -clear-ast-before-backend -disable-llvm-verifier -discard-value-names -main-file-name sycl-usm.cpp -mrelocation-model pic -pic-level 2 -pic-is-pie -mframe-pointer=none -fmath-errno -ffp-contract=on -fno-rounding-math -mconstructor-aliases -funwind-tables=2 -target-cpu x86-64 -tune-cpu generic -mllvm -treat-scalable-fixed-error-as-warning -debugger-tuning=gdb -fcoverage-compilation-dir=/home/zm23374/lats -resource-dir /usr/lib/llvm-14/lib/clang/14.0.0 -D ENABLE_PROFILING -I /home/zm23374/Apps/spack/opt/spack/linux-ubuntu22.04-skylake/gcc-11.4.0/intel-oneapi-compilers-2023.2.1-xq4ylpocz5g63twqrwf4xqmymwuuam2v/compiler/2023.2.1/linux/lib/oclfpga/include -I/home/zm23374/Apps/spack/opt/spack/linux-ubuntu22.04-skylake/gcc-11.4.0/intel-oneapi-compilers-2023.2.1-xq4ylpocz5g63twqrwf4xqmymwuuam2v/compiler/2023.2.1/linux/lib/oclfpga/include -internal-isystem /usr/lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12 -internal-isystem /usr/lib/gcc/x86_64-linux-gnu/12/../../../../include/x86_64-linux-gnu/c++/12 -internal-isystem /usr/lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12/backward -internal-isystem /usr/lib/llvm-14/lib/clang/14.0.0/include -internal-isystem /usr/local/include -internal-isystem /usr/lib/gcc/x86_64-linux-gnu/12/../../../../x86_64-linux-gnu/include -internal-externc-isystem /usr/include/x86_64-linux-gnu -internal-externc-isystem /include -internal-externc-isystem /usr/include -O3 -fdeprecated-macro -fdebug-compilation-dir=/home/zm23374/lats -ferror-limit 19 -fgnuc-version=4.2.1 -fcxx-exceptions -fexceptions -vectorize-loops -vectorize-slp -faddrsig -D__GCC_HAVE_DWARF2_CFI_ASM=1 -x c++ /home/zm23374/lats/sycl-usm.cpp
I[00:39:37.464] Building preamble...
I[00:39:37.578] Indexing headers...
E[00:39:37.622] [pp_file_not_found] Line 2: 'sycl/sycl.hpp' file not found
I[00:39:37.622] Building AST...
E[00:39:37.636] [unknown_typename] Line 21: unknown type name 'SYCL_EXTERNAL'
E[00:39:37.636] [attribute_wrong_decl_type_str] Line 21: 'overloadable' attribute only applies to functions
E[00:39:37.636] [invalid_token_after_toplevel_declarator] Line 22: expected ';' after top level declarator
E[00:39:37.636] [undeclared_var_use] Line 26: use of undeclared identifier 'sycl'
E[00:39:37.636] [undeclared_var_use] Line 42: use of undeclared identifier 'intel_get_cycle_counter'
E[00:39:37.636] [undeclared_var_use] Line 80: use of undeclared identifier 'intel_get_cycle_counter'
E[00:39:37.636] [undeclared_var_use] Line 85: use of undeclared identifier 'sycl'
E[00:39:37.636] [undeclared_var_use] Line 106: use of undeclared identifier 'sycl'
E[00:39:37.636] [undeclared_var_use] Line 106: use of undeclared identifier 'sycl'
E[00:39:37.636] [undeclared_var_use] Line 110: use of undeclared identifier 'sycl'
E[00:39:37.636] [undeclared_var_use] Line 116: use of undeclared identifier 'sycl'
E[00:39:37.636] [expected_lparen_after_type] Line 116: expected '(' for function-style cast or type construction
E[00:39:37.636] [undeclared_var_use] Line 117: use of undeclared identifier 'sycl'
E[00:39:37.636] [expected_lparen_after_type] Line 117: expected '(' for function-style cast or type construction
E[00:39:37.636] [undeclared_var_use] Line 127: use of undeclared identifier 'sycl'
E[00:39:37.636] [expected_lparen_after_type] Line 127: expected '(' for function-style cast or type construction
E[00:39:37.636] [undeclared_var_use] Line 129: use of undeclared identifier 'sycl'
E[00:39:37.636] [expected_lparen_after_type] Line 129: expected '(' for function-style cast or type construction
E[00:39:37.636] [undeclared_var_use] Line 137: use of undeclared identifier 'sycl'
E[00:39:37.636] [fatal_too_many_errors] Line 1: too many errors emitted, stopping now
I[00:39:37.636] Indexing AST...
I[00:39:37.637] Testing features at each token (may be slow in large files)
I[00:39:37.650] Found definition heuristically using nearby identifier ulong
I[00:39:37.653] Found definition heuristically in index for printf
I[00:39:37.653] Found definition heuristically in index for printf
I[00:39:37.692] Found definition heuristically using nearby identifier size_t
I[00:39:37.692] Found definition heuristically using nearby identifier printf
I[00:39:37.692] Found definition heuristically using nearby identifier printf
I[00:39:37.693] Found definition heuristically using nearby identifier printf
I[00:39:37.693] Found definition heuristically using nearby identifier printf
I[00:39:37.693] Found definition heuristically using nearby identifier h_cycles
I[00:39:37.697] All checks completed, 21 errors
This is what I got instead.
The first error in this log is
E[00:39:37.622] [pp_file_not_found] Line 2: 'sycl/sycl.hpp' file not found
As mentioned in an earlier comment, you may need to manually specify the include flag that allows the compiler to find this header. You can do that with https://clangd.llvm.org/config.html#add.
@HighCommander4 Please correct me if I'm wrong, but there are many sycl references in the arguments? section of this compile_commands.json. I thought this is what you meant when you wanted to add -fsycl flags.
[
{
"arguments": [
"/home/zm23374/Apps/spack/opt/spack/linux-ubuntu22.04-skylake/gcc-11.4.0/intel-oneapi-compilers-2023.2.1-xq4ylpocz5g63twqrwf4xqmymwuuam2v/compiler/2023.2.1/linux/bin/icx",
"-O3",
"-std=gnu99",
"-c",
"-I",
"/home/zm23374/Apps/spack/opt/spack/linux-ubuntu22.04-skylake/gcc-11.4.0/intel-oneapi-compilers-2023.2.1-xq4ylpocz5g63twqrwf4xqmymwuuam2v/compiler/2023.2.1/linux/lib/oclfpga/include",
"-o",
"profiler.o",
"profiler.c"
],
"directory": "/home/zm23374/lats",
"file": "/home/zm23374/lats/profiler.c",
"output": "/home/zm23374/lats/profiler.o"
},
{
"arguments": [
"/home/zm23374/Apps/spack/opt/spack/linux-ubuntu22.04-skylake/gcc-11.4.0/intel-oneapi-compilers-2023.2.1-xq4ylpocz5g63twqrwf4xqmymwuuam2v/compiler/2023.2.1/linux/bin/icpx",
"-O3",
"-fsycl",
"-DENABLE_PROFILING",
"-c",
"-I",
"/home/zm23374/Apps/spack/opt/spack/linux-ubuntu22.04-skylake/gcc-11.4.0/intel-oneapi-compilers-2023.2.1-xq4ylpocz5g63twqrwf4xqmymwuuam2v/compiler/2023.2.1/linux/lib/oclfpga/include",
"-o",
"obj_sycl.o",
"sycl-usm.cpp"
],
"directory": "/home/zm23374/lats",
"file": "/home/zm23374/lats/sycl-usm.cpp",
"output": "/home/zm23374/lats/obj_sycl.o"
},
{
"arguments": [
"/home/zm23374/Apps/spack/opt/spack/linux-ubuntu22.04-skylake/gcc-11.4.0/intel-oneapi-compilers-2023.2.1-xq4ylpocz5g63twqrwf4xqmymwuuam2v/compiler/2023.2.1/linux/bin-llvm/clang",
"-cc1",
"-triple",
"spir64-unknown-unknown",
"-aux-triple",
"x86_64-unknown-linux-gnu",
"-fsycl-is-device",
"-fdeclare-spirv-builtins",
"-mllvm",
"-sycl-opt",
"-fenable-sycl-dae",
"-fsycl-instrument-device-code",
"-Wno-sycl-strict",
"-fsycl-int-header=/tmp/icpx-4c3d0d/sycl-usm-header-d730e1.h",
"-fsycl-int-footer=/tmp/icpx-4c3d0d/sycl-usm-footer-7abb6e.h",
"-sycl-std=2020",
"-ffine-grained-bitfield-accesses",
"-fsycl-unique-prefix=578359edf978f046",
"-Wspir-compat",
"-emit-llvm-bc",
"-emit-llvm-uselists",
"-disable-free",
"-clear-ast-before-backend",
"-disable-llvm-verifier",
"-discard-value-names",
"-main-file-name",
"-fsycl-use-main-file-name",
"-full-main-file-name",
"-mrelocation-model",
"static",
"-fveclib=SVML",
"-mframe-pointer=all",
"-menable-no-infs",
"-menable-no-nans",
"-fapprox-func",
"-funsafe-math-optimizations",
"-fno-signed-zeros",
"-mreassociate",
"-freciprocal-math",
"-fdenormal-fp-math=preserve-sign,preserve-sign",
"-ffp-contract=fast",
"-fno-rounding-math",
"-ffast-math",
"-ffinite-math-only",
"-fno-verbose-asm",
"-mconstructor-aliases",
"-aux-target-cpu",
"x86-64",
"-debugger-tuning=gdb",
"-resource-dir",
"/home/zm23374/Apps/spack/opt/spack/linux-ubuntu22.04-skylake/gcc-11.4.0/intel-oneapi-compilers-2023.2.1-xq4ylpocz5g63twqrwf4xqmymwuuam2v/compiler/2023.2.1/linux/lib/clang/17",
"-internal-isystem",
"/home/zm23374/Apps/spack/opt/spack/linux-ubuntu22.04-skylake/gcc-11.4.0/intel-oneapi-compilers-2023.2.1-xq4ylpocz5g63twqrwf4xqmymwuuam2v/compiler/2023.2.1/linux/bin-llvm/../include/sycl",
"-internal-isystem",
"/home/zm23374/Apps/spack/opt/spack/linux-ubuntu22.04-skylake/gcc-11.4.0/intel-oneapi-compilers-2023.2.1-xq4ylpocz5g63twqrwf4xqmymwuuam2v/compiler/2023.2.1/linux/bin-llvm/../include",
"-D",
"ENABLE_PROFILING",
"-I/home/zm23374/Apps/spack/opt/spack/linux-ubuntu22.04-skylake/gcc-11.4.0/intel-oneapi-compilers-2023.2.1-xq4ylpocz5g63twqrwf4xqmymwuuam2v/compiler/2023.2.1/linux/lib/oclfpga/include",
"-internal-isystem",
"/home/zm23374/Apps/spack/opt/spack/linux-ubuntu22.04-skylake/gcc-11.4.0/intel-oneapi-compilers-2023.2.1-xq4ylpocz5g63twqrwf4xqmymwuuam2v/compiler/2023.2.1/linux/bin-llvm/../compiler/include",
"-internal-isystem",
"/usr/lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12",
"-internal-isystem",
"/usr/lib/gcc/x86_64-linux-gnu/12/../../../../include/x86_64-linux-gnu/c++/12",
"-internal-isystem",
"/usr/lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12/backward",
"-internal-isystem",
"/usr/lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12",
"-internal-isystem",
"/usr/lib/gcc/x86_64-linux-gnu/12/../../../../include/x86_64-linux-gnu/c++/12",
"-internal-isystem",
"/usr/lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12/backward",
"-internal-isystem",
"/home/zm23374/Apps/spack/opt/spack/linux-ubuntu22.04-skylake/gcc-11.4.0/intel-oneapi-compilers-2023.2.1-xq4ylpocz5g63twqrwf4xqmymwuuam2v/compiler/2023.2.1/linux/lib/clang/17/include",
"-internal-isystem",
"/usr/local/include",
"-internal-isystem",
"/usr/lib/gcc/x86_64-linux-gnu/12/../../../../x86_64-linux-gnu/include",
"-internal-externc-isystem",
"/usr/include/x86_64-linux-gnu",
"-internal-externc-isystem",
"/include",
"-internal-externc-isystem",
"/usr/include",
"-internal-isystem",
"/home/zm23374/Apps/spack/opt/spack/linux-ubuntu22.04-skylake/gcc-11.4.0/intel-oneapi-compilers-2023.2.1-xq4ylpocz5g63twqrwf4xqmymwuuam2v/compiler/2023.2.1/linux/lib/clang/17/include",
"-internal-isystem",
"/usr/local/include",
"-internal-isystem",
"/usr/lib/gcc/x86_64-linux-gnu/12/../../../../x86_64-linux-gnu/include",
"-internal-externc-isystem",
"/usr/include/x86_64-linux-gnu",
"-internal-externc-isystem",
"/include",
"-internal-externc-isystem",
"/usr/include",
"-O3",
"-std=c++17",
"-fdeprecated-macro",
"-fdebug-compilation-dir=/home/zm23374/lats",
"-ferror-limit",
"19",
"-fheinous-gnu-extensions",
"-fgpu-rdc",
"-fgnuc-version=4.2.1",
"-no-opaque-pointers",
"-fcxx-exceptions",
"-fexceptions",
"-mllvm",
"-enable-gvn-hoist",
"-fcolor-diagnostics",
"-vectorize-loops",
"-vectorize-slp",
"-D__GCC_HAVE_DWARF2_CFI_ASM=1",
"-fintel-compatibility",
"-fintel-compatibility-disable=FakeLoad",
"-fintel-libirc-allowed",
"-mllvm",
"-disable-hir-generate-mkl-call",
"-mllvm",
"-intel-abi-compatible=true",
"-x",
"c++",
"-I",
"/home/zm23374/Apps/spack/opt/spack/linux-ubuntu22.04-skylake/gcc-11.4.0/intel-oneapi-compilers-2023.2.1-xq4ylpocz5g63twqrwf4xqmymwuuam2v/compiler/2023.2.1/linux/lib/oclfpga/include",
"-o",
"/tmp/icpx-4c3d0d/sycl-usm-86bdd3.bc",
"sycl-usm.cpp"
],
"directory": "/home/zm23374/lats",
"file": "/home/zm23374/lats/sycl-usm.cpp",
"output": "/tmp/icpx-4c3d0d/sycl-usm-86bdd3.bc"
},
{
"arguments": [
"/home/zm23374/Apps/spack/opt/spack/linux-ubuntu22.04-skylake/gcc-11.4.0/intel-oneapi-compilers-2023.2.1-xq4ylpocz5g63twqrwf4xqmymwuuam2v/compiler/2023.2.1/linux/bin-llvm/clang",
"-cc1",
"-triple",
"x86_64-unknown-linux-gnu",
"-sycl-std=2020",
"-fsycl-unique-prefix=578359edf978f046",
"-include",
"/tmp/icpx-4c3d0d/sycl-usm-header-d730e1.h",
"-dependency-filter",
"-fsycl-enable-int-header-diags",
"-fsycl-is-host",
"-emit-obj",
"-disable-free",
"-clear-ast-before-backend",
"-disable-llvm-verifier",
"-discard-value-names",
"-main-file-name",
"-fsycl-use-main-file-name",
"-full-main-file-name",
"-mrelocation-model",
"static",
"-fveclib=SVML",
"-mframe-pointer=none",
"-menable-no-infs",
"-menable-no-nans",
"-fapprox-func",
"-funsafe-math-optimizations",
"-fno-signed-zeros",
"-mreassociate",
"-freciprocal-math",
"-fdenormal-fp-math=preserve-sign,preserve-sign",
"-ffp-contract=fast",
"-fno-rounding-math",
"-ffast-math",
"-ffinite-math-only",
"-mconstructor-aliases",
"-funwind-tables=2",
"-target-cpu",
"x86-64",
"-mllvm",
"-x86-enable-unaligned-vector-move=true",
"-tune-cpu",
"generic",
"--dependent-lib=sycl-devicelib-host",
"-debugger-tuning=gdb",
"-fcoverage-compilation-dir=/home/zm23374/lats",
"-resource-dir",
"/home/zm23374/Apps/spack/opt/spack/linux-ubuntu22.04-skylake/gcc-11.4.0/intel-oneapi-compilers-2023.2.1-xq4ylpocz5g63twqrwf4xqmymwuuam2v/compiler/2023.2.1/linux/lib/clang/17",
"-internal-isystem",
"/home/zm23374/Apps/spack/opt/spack/linux-ubuntu22.04-skylake/gcc-11.4.0/intel-oneapi-compilers-2023.2.1-xq4ylpocz5g63twqrwf4xqmymwuuam2v/compiler/2023.2.1/linux/bin-llvm/../include/sycl",
"-internal-isystem",
"/home/zm23374/Apps/spack/opt/spack/linux-ubuntu22.04-skylake/gcc-11.4.0/intel-oneapi-compilers-2023.2.1-xq4ylpocz5g63twqrwf4xqmymwuuam2v/compiler/2023.2.1/linux/bin-llvm/../include",
"-iquote",
"/home/zm23374/lats",
"-D",
"ENABLE_PROFILING",
"-I/home/zm23374/Apps/spack/opt/spack/linux-ubuntu22.04-skylake/gcc-11.4.0/intel-oneapi-compilers-2023.2.1-xq4ylpocz5g63twqrwf4xqmymwuuam2v/compiler/2023.2.1/linux/lib/oclfpga/include",
"-internal-isystem",
"/home/zm23374/Apps/spack/opt/spack/linux-ubuntu22.04-skylake/gcc-11.4.0/intel-oneapi-compilers-2023.2.1-xq4ylpocz5g63twqrwf4xqmymwuuam2v/compiler/2023.2.1/linux/bin-llvm/../compiler/include",
"-internal-isystem",
"/usr/lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12",
"-internal-isystem",
"/usr/lib/gcc/x86_64-linux-gnu/12/../../../../include/x86_64-linux-gnu/c++/12",
"-internal-isystem",
"/usr/lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12/backward",
"-internal-isystem",
"/usr/lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12",
"-internal-isystem",
"/usr/lib/gcc/x86_64-linux-gnu/12/../../../../include/x86_64-linux-gnu/c++/12",
"-internal-isystem",
"/usr/lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12/backward",
"-internal-isystem",
"/home/zm23374/Apps/spack/opt/spack/linux-ubuntu22.04-skylake/gcc-11.4.0/intel-oneapi-compilers-2023.2.1-xq4ylpocz5g63twqrwf4xqmymwuuam2v/compiler/2023.2.1/linux/lib/clang/17/include",
"-internal-isystem",
"/usr/local/include",
"-internal-isystem",
"/usr/lib/gcc/x86_64-linux-gnu/12/../../../../x86_64-linux-gnu/include",
"-internal-externc-isystem",
"/usr/include/x86_64-linux-gnu",
"-internal-externc-isystem",
"/include",
"-internal-externc-isystem",
"/usr/include",
"-internal-isystem",
"/home/zm23374/Apps/spack/opt/spack/linux-ubuntu22.04-skylake/gcc-11.4.0/intel-oneapi-compilers-2023.2.1-xq4ylpocz5g63twqrwf4xqmymwuuam2v/compiler/2023.2.1/linux/lib/clang/17/include",
"-internal-isystem",
"/usr/local/include",
"-internal-isystem",
"/usr/lib/gcc/x86_64-linux-gnu/12/../../../../x86_64-linux-gnu/include",
"-internal-externc-isystem",
"/usr/include/x86_64-linux-gnu",
"-internal-externc-isystem",
"/include",
"-internal-externc-isystem",
"/usr/include",
"-O3",
"-std=c++17",
"-fdeprecated-macro",
"-fdebug-compilation-dir=/home/zm23374/lats",
"-ferror-limit",
"19",
"-fheinous-gnu-extensions",
"-fgpu-rdc",
"-fgnuc-version=4.2.1",
"-fcxx-exceptions",
"-fexceptions",
"-mllvm",
"-enable-gvn-hoist",
"-fcolor-diagnostics",
"-vectorize-loops",
"-vectorize-slp",
"-D__GCC_HAVE_DWARF2_CFI_ASM=1",
"-fintel-compatibility",
"-fintel-libirc-allowed",
"-mllvm",
"-disable-hir-generate-mkl-call",
"-mllvm",
"-sycl-host",
"-mllvm",
"-loopopt=1",
"-floopopt-pipeline=light",
"-mllvm",
"-intel-abi-compatible=true",
"-x",
"c++",
"-I",
"/home/zm23374/Apps/spack/opt/spack/linux-ubuntu22.04-skylake/gcc-11.4.0/intel-oneapi-compilers-2023.2.1-xq4ylpocz5g63twqrwf4xqmymwuuam2v/compiler/2023.2.1/linux/lib/oclfpga/include",
"-o",
"/tmp/icpx-4c3d0d/sycl-usm-874778.o",
"sycl-usm.cpp"
],
"directory": "/home/zm23374/lats",
"file": "/home/zm23374/lats/sycl-usm.cpp",
"output": "/tmp/icpx-4c3d0d/sycl-usm-874778.o"
}
]
This clangd is from the apt repo
Only clangd from intel/llvm can parse SYCL headers from intel/llvm. The workaround for this issue from https://github.com/intel/llvm/pull/11795 cannot be upstreamed because it depends on compiler driver options that are only present in intel/llvm. Upstreaming the workaround will be only possible if these options are also upstreamed.
Additionally, note the workaround was merged only recently and there hasn't been any Intel oneAPI toolkit releases which contain it yet. As of today, you can only parse DPC++ SYCL headers in clangd if you build it yourself from https://github.com/intel/llvm. Intel's oneAPI toolkit does ship its own clangd builds, but I expect the fixed version will only be released in a few months. The version you're using (2023.2.1) was released before the PR was opened.
@rafbiels I will see if 2024.0.2 has this support. If not, I don't mind bootstrapping llvm. But I do have one question as I'm a bit confused about how clangd handles headers. So far, my understanding was that it uses the compiler provided (in my case icpx or dpcpp) and runs it to fetch the errors etc. I wasn't aware that it uses the default clang installed by my package manager or an internal clang for that matter. If that's the case, how does it manage to parse cuda or rocm code? In that case you'd need nvhpc or rocm right?
@HighCommander4 Please correct me if I'm wrong, but there are many sycl references in the arguments? section of this compile_commands.json.
The posted snippet contains multiple entries with "file": "/home/zm23374/lats/sycl-usm.cpp". In a situation like this, clangd will pick the first one (or perhaps an unspecified one, and it happens to pick the first one in this case), and the first one in your case contains relatively few flags.
So far, my understanding was that it uses the compiler provided (in my case icpx or dpcpp) and runs it to fetch the errors etc. I wasn't aware that it uses the default clang installed by my package manager or an internal clang for that matter.
Clangd does not use any external program for parsing code and producing diagnostics; it uses, within its own process, a copy of the clang libraries shipped as part of the clangd package.
@HighCommander4 I see. It does make sense why my setup doesn't work then. The setup's a bit complicated, but I just checked that clang indeed supports cuda, which solves my confusion. I'm not sure how to set up an alternate clang with emacs, but I'm sure there's a way. Will get back here if I'm successful in getting it working.
As a casual viewer of this issue with the same problem,
Thanks for this fix!, @rafbiels
Works if I compile it myself and use it locally (does not appear to be in oneAPI 2024.0.2 but works with it).
Commands I used,
git clone https://github.com/intel/llvm.git
cd llvm/buildbot
python3 configure.py --ci-defaults --no-assertions -t Release
python3 compile.py -j 20 -t clang
python3 compile.py -j 20 -t sycl
python3 compile.py -j 20 -t clangd
cd ../build
sudo cp bin/clangd /usr/local/bin
Also I had to add this (but this may be a problem with my configuration):
set(CMAKE_CXX_STANDARD_INCLUDE_DIRECTORIES ${CMAKE_CXX_IMPLICIT_INCLUDE_DIRECTORIES})
