Javad Shafique

Results 26 comments of Javad Shafique
trafficstars

Hi @kumaraditya303, i should be able to test it. Have you seen the suggested PR, iirc you are on as a reviewer.

Hi again @kumaraditya303, a similar issue also exists in uvloop, where it does not correctly handle the underlying socket being closed, i've generalized my first example to work in all...

(It would appear the flake8 version CI/CD is using is old enough to have issues haha, locally everything is good and the error is nonsensical, do advise it and on...

Minimal repo here: https://github.com/cjavad/python-hypercorn-issue-125981-repo

> Please try to trace it with Valrind > > USE_ZEND_ALLOC=0 valgrind php your_code.php Yes i would love to be able to do this, this only happens in production though,...

I have been able to confirm the issue to be an use after free from `Coroutine::on_close` -> `PHPContext::on_close` -> `efree(ctx)` being called before `restore_og` on the PHPContext perhaps a race...

Hi @matyhtf, still no luck reproducing in testing, i'll have to evaluate if the 2x performance degradation makes sense to try to run it in production. At a high level...

Hi again @matyhtf recently getting very consistent segfaults, all in php `unserialize`. I am noticing swoole does not seem to handle the `BG(v)` global variables used by `var_serializer.c` which could...

Will test, thank you! **Edit**: Deployed into production successfully, no immediately faults, i'll report back tomorrow, and then again after a week, fingers crossed haha. The current pattern of the...

That did something, getting a rare segfault in `swoole::MsgQueue::MsgQueue(int, bool, int) + 48 in section .text` now, these segfaults have the same very consistent offset so i doubt there is...