gh-submit-queue icon indicating copy to clipboard operation
gh-submit-queue copied to clipboard

Published 20 hours ago • verified publisher icon cirruslabs

Master with failed commit

Open cdsap opened this issue 5 years ago • 4 comments

Hi, thank you very much for this tool. I'm testing the SubmitQueue in a simple repository and I have one commit failing in master: Screen Shot 2020-04-06 at 4 41 58 PM

When I'm creating a new PR(without fixing the build) I see: Screen Shot 2020-04-06 at 4 42 14 PM

It shouldn't fail the check for the Submit Queue in this case where I have master failing?

Thanks

cdsap avatar Apr 06 '20 23:04 cdsap

Interesting. Is is it for a public repository or private? Also just to confirm this PR targets the failing branch, right?

fkorotkov avatar Apr 07 '20 00:04 fkorotkov

I can see the problem. It seems Circle doesn't create Check Suites and creates Commit Statuses. The app doesn't support checking commit statuses yet. You might want to follow this docs to enable Check Suite API for Circle: https://circleci.com/docs/2.0/enable-checks/

fkorotkov avatar Apr 07 '20 00:04 fkorotkov

Created #5 to add support for tools that still use Status API

fkorotkov avatar Apr 07 '20 00:04 fkorotkov

Thanks! Checking the CircleCI Checks. I will follow #5 to check the updates.

cdsap avatar Apr 07 '20 00:04 cdsap