ember-power-select icon indicating copy to clipboard operation
ember-power-select copied to clipboard

Published 20 hours ago • verified publisher icon cibernox

Add wrapper div around options & afterOptionsComponent

Open nickschot opened this issue 7 years ago • 4 comments

@cibernox this is the second feature request I made in Discord. This enables the following change: https://github.com/weddingshoppe/ember-model-select/pull/6/files#diff-6cd7a1538e5e1eb6201624d486136991 meaning the loading mask height is independent of any style changes that are made to the search component.

nickschot avatar Sep 12 '18 13:09 nickschot

Heh, it seems something odd happened with rebasing. Just need to look at the power-select.hbs change (which is the div).

nickschot avatar Sep 12 '18 13:09 nickschot

@nickschot I realize this is super old, but could you please rebase and fix conflicts?

RobbieTheWagner avatar Aug 05 '22 16:08 RobbieTheWagner

@nickschot I realize this is super old, but could you please rebase and fix conflicts?

Not sure what was up with my branch, was a bit weird. But since it's a one liner I've just started afresh master again. Should be fixed.

edit: oh my comment from 2018 already said something weird was going on 😂

nickschot avatar Oct 01 '22 14:10 nickschot

Thanks @nickschot! Is there any possibility this would break things for some people or not? I'm trying to help out maintaining things here, but I am not super familiar with the internals.

RobbieTheWagner avatar Oct 02 '22 01:10 RobbieTheWagner