ember-native-dom-helpers icon indicating copy to clipboard operation
ember-native-dom-helpers copied to clipboard

Published 20 hours ago • verified publisher icon cibernox

Improve deprecations

Open cibernox opened this issue 7 years ago • 3 comments
trafficstars

@iezer I'm working on improving the deprecations.

cibernox avatar Feb 21 '18 23:02 cibernox

@cibernox Awesome, thanks for picking this up. I wonder if it's possible to detect if a user is using the old syntax of moduleFor and passing beforeEach and afterEach, versus the new syntax of calling module and setupRenderingTest.

iezer avatar Feb 22 '18 15:02 iezer

@iezer That is what I'm doing here: https://github.com/cibernox/ember-native-dom-helpers/pull/145/files#diff-36ccf1b6880df69c7336caa0370773df

I'll try to find time to finish it tomorrow or on saturday.

cibernox avatar Feb 22 '18 15:02 cibernox

👍 That looks great. I misread that as merely checking for @ember/test-helpers but now I see you're checking !!getContext()

iezer avatar Feb 22 '18 15:02 iezer