Miguel Camba

Results 297 comments of Miguel Camba
trafficstars

I say that I've been on a transoceanic flight for the last 12 hours and nothing productive will come out of my brain today. Tomorrow I'll read this issue again...

Thanks for reporting this. I haven't tried this in the latest ember-cli, I'll try to reproduce it tomorrow

I couldn't dig into this past week, but I did today and I wasn't able to reproduce it. do you still have this issue?

Yesterday I tried this in a brand new application generated with `ember new` and worked, so I feel that this must be some collision between this addon and another one....

Thank for reporting those issues. I'll find time this weekend for tackle them

We must make this not rely on any specific version of `@glimmer/syntax` but use `this.syntax` from whatever version the app uses

I need to revisit this, I believe we shouldn't be importing the syntax from anywhere but rather access whatever version is available in the context.

I like the approach. There is a benefit not listed here that probably is not a big deal, but this approach with explicit imports is friendly to treeshaking, whereas having...

@GavinJoyce May I take some advice on how to measure the perf of this change? I imagine that setting an observer won't affect performance that much (although all helpers will...

@GavinJoyce That would be great. That said, don't merge it yet. I need to test more edge cases. - Transition from `/foo/bar?one=1&two=2` with `{{href-to 'foo.qux'}}`, where `one` is a qp...