Miguel Camba

Results 297 comments of Miguel Camba
trafficstars

I like the idea, let's do it. In fact, I think that this should be the new default, instead of `proximitySelection: false` as it is today.

Makes sense. Go ahead. I don't see the point in allowing to customize the key combination for now, as nobody has really asked for it. Let's stick to `shift +...

If you pass `onCenterChange=(action "someAction")`, you can inside that action check if the previous month is invalid and just do nothing. You can also pass your own custom `calendar.nav` component...

I think you'll have to receive arguments with `withLocale(...args)` and remove the last one as it will be the callback.

@koryteg only firefox? Interesting. I'll check it. Can you check if the tests pass on firefox and if they do, create a failing test that exercises this error?

FWIW, I did not find a way to reproduce this, but I suspect the reason. There is a part of the code where I compare dates on a while and...

It's a bit more complex, as you would have to also update whatever was focused before so it's not focused anymore, but I'm not opposed if you add tests that...

It's more the opposite. Why have ember objects if you don't have to? I stick to POJOs as much as I can. Also with the plan to migrate the addon...

Sorry, I forgot about this. Reviewing