Christian Vadalà

Results 52 comments of Christian Vadalà

That's fine, I'm going to close the other PR. Anyway, I commented your code there and I see that same requests apply here. Can you review your code? Thanks

No, it doesn't, the current version doesn't support units. You can see supported use cases on the related unit test https://github.com/chrvadala/transformation-matrix/blob/main/test/fromTransformAttribute.pegjs.spec.js

> Errors also seem to affect node v14 as well Unfortunately the linked PR hasn't been merged https://github.com/TooTallNate/node-lame/pull/99

To analyze https://github.com/devowlio/node-lame as valid alternative to the deprecated node-lame

Hello @nmasse-itix thanks for your feedback. I think that node-ble can easily replace noble ( I developed it for this reason). Below an answer to your points > Expose the...

Thanks for your PR. I need some time to review it, I will provide some feedbacks as soon as possible

Hi @nmasse-itix, unfortunately with the current design these listeners have to be removed, otherwise there's a potential memory leak. They were introduced by this PR https://github.com/chrvadala/node-ble/issues/72. I think that the...