chrono icon indicating copy to clipboard operation
chrono copied to clipboard

Published 20 hours ago • verified publisher icon chronotope

Update rkyv requirement from 0.7.43 to 0.8.3

Open dependabot[bot] opened this issue 1 year ago • 7 comments

Updates the requirements on rkyv to permit the latest version.

Commits

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

dependabot[bot] avatar Sep 16 '24 04:09 dependabot[bot]

I don't think we're going to be able to merge this in chrono 0.4.

djc avatar Sep 16 '24 07:09 djc

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

dependabot[bot] avatar Sep 16 '24 07:09 dependabot[bot]

Did you re-open for a reason?

pitdicker avatar Sep 16 '24 08:09 pitdicker

Mostly so people can more easily find it if they look for it -- labeled as "API-incompatible".

djc avatar Sep 16 '24 08:09 djc

The CI should be green or less red if we use the new feature names. size_16 is renamed to pointer_width_16, and the same for size_32 and size_64.

pitdicker avatar Sep 16 '24 08:09 pitdicker

I'm happy to impelement this with something like rkyv-07 and rkyv-08 features, it doesn't have to be breaking (you could keep rkyv feature as is and have rkyv-08 feature). The rkyv-XY features for pointer width and rkyv-validation would probably have to be versioned similarly, as I don't think it's possible to toggle different optional dependency features based on whether some feature is set or not.

Awpteamoose avatar Sep 30 '24 10:09 Awpteamoose

I'm happy to impelement this with something like rkyv-07 and rkyv-08 features, it doesn't have to be breaking (you could keep rkyv feature as is and have rkyv-08 feature). The rkyv-XY features for pointer width and rkyv-validation would probably have to be versioned similarly, as I don't think it's possible to toggle different optional dependency features based on whether some feature is set or not.

I'd review a PR that adds a set of rkyv-08 features.

djc avatar Oct 01 '24 07:10 djc

Superseded by #1737.

dependabot[bot] avatar Sep 22 '25 04:09 dependabot[bot]