chrono
chrono copied to clipboard
Create the subsec_millis and subsec_micros methods for Duration
Fixes #1348
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
15c8885) 91.61% compared to head (10cd25f) 91.63%. Report is 3 commits behind head on 0.4.x.
Additional details and impacted files
@@ Coverage Diff @@
## 0.4.x #1351 +/- ##
==========================================
+ Coverage 91.61% 91.63% +0.01%
==========================================
Files 38 38
Lines 17482 17519 +37
==========================================
+ Hits 16016 16053 +37
Misses 1466 1466
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Sorry I took a while @jtmoon79 I addressed your comments and rebased to make my commits match @djc's suggestion
@botahamec Do you want to push this PR over the finish line? Please adjust the commits a bit more matching @djc's request, and adjust the type of MICROS_PER_SEC.
Note that we will hopefully merge two PRs the next few days that touch surrounding code: https://github.com/chronotope/chrono/pull/1337 and https://github.com/chronotope/chrono/pull/1385. You may want to wait with rebasing until that is done.
Note that we will hopefully merge two PRs the next few days that touch surrounding code: #1337 and #1385. You may want to wait with rebasing until that is done.
They are merged now.
@botahamec Can you let us now if you are still interested in working on this PR?
Closing due to inactivity.