chrono icon indicating copy to clipboard operation
chrono copied to clipboard

Create the subsec_millis and subsec_micros methods for Duration

Open botahamec opened this issue 2 years ago • 5 comments

Fixes #1348

botahamec avatar Nov 04 '23 20:11 botahamec

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (15c8885) 91.61% compared to head (10cd25f) 91.63%. Report is 3 commits behind head on 0.4.x.

Additional details and impacted files
@@            Coverage Diff             @@
##            0.4.x    #1351      +/-   ##
==========================================
+ Coverage   91.61%   91.63%   +0.01%     
==========================================
  Files          38       38              
  Lines       17482    17519      +37     
==========================================
+ Hits        16016    16053      +37     
  Misses       1466     1466              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 04 '23 20:11 codecov[bot]

Sorry I took a while @jtmoon79 I addressed your comments and rebased to make my commits match @djc's suggestion

botahamec avatar Nov 19 '23 14:11 botahamec

@botahamec Do you want to push this PR over the finish line? Please adjust the commits a bit more matching @djc's request, and adjust the type of MICROS_PER_SEC.

Note that we will hopefully merge two PRs the next few days that touch surrounding code: https://github.com/chronotope/chrono/pull/1337 and https://github.com/chronotope/chrono/pull/1385. You may want to wait with rebasing until that is done.

pitdicker avatar Jan 30 '24 16:01 pitdicker

Note that we will hopefully merge two PRs the next few days that touch surrounding code: #1337 and #1385. You may want to wait with rebasing until that is done.

They are merged now.

pitdicker avatar Feb 02 '24 07:02 pitdicker

@botahamec Can you let us now if you are still interested in working on this PR?

pitdicker avatar Feb 21 '24 16:02 pitdicker

Closing due to inactivity.

pitdicker avatar Mar 08 '24 10:03 pitdicker