chroma
chroma copied to clipboard
[Bug]: Ensure `pyproject.toml` is correct as part of CI for PRs.
What happened?
The dependencies in requirements.txt and pyproject.toml must match in order for the project to work correctly in development and when deployed.
However, there is currently no automated mechanism for ensuring that this is the case, except for the build-and-release job, which only runs on main.
We should call the bin/test-package.sh script as part of our CI on PRs to avoid this in the future.
Versions
All
Relevant log output
No response
Hey @levand @jeffchuber. I would love to work on this one if this issue is not already taken.
I just had a question as what to do when we find requirements.txt and pyproject.toml are not in sync?
Thank you! We'd just want a GitHub action that fails if they are out of sync
@HammadB So ToDo for me would be just to create a shell script to see if requirements and pyproject.toml packages match and make a new workflow to trigger this script? Right? I am not sure what do we mean by the line "We should call the bin/test-package.sh script as part of our CI on PRs to avoid this in the future." Can you please help me if I am getting this wrong?
@levand @HammadB @jeffchuber I have made a DRAFT PR for this issue, I just wanted to make sure if everyone here agree to the approach of the shell script.🙂