chroma icon indicating copy to clipboard operation
chroma copied to clipboard

Published 20 hours ago • verified publisher icon chroma-core

[PERF] prefetch blocks for fulltext index writer

Open codetheweb opened this issue 11 months ago • 2 comments

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • ...
  • New functionality
    • ...

Test plan

How are these changes tested?

  • [ ] Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

codetheweb avatar Dec 30 '24 19:12 codetheweb

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • [ ] Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • [ ] Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • [ ] If appropriate, are there adequate property based tests?
  • [ ] If appropriate, are there adequate unit tests?
  • [ ] Should any logging, debugging, tracing information be added or removed?
  • [ ] Are error messages user-friendly?
  • [ ] Have all documentation changes needed been made?
  • [ ] Have all non-obvious changes been commented?

System Compatibility

  • [ ] Are there any potential impacts on other parts of the system or backward compatibility?
  • [ ] Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • [ ] Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

github-actions[bot] avatar Dec 30 '24 19:12 github-actions[bot]

I think @sanketkedia should weigh in on this before merge, as we have operators for prefetch and established patterns for it

I will ask I originally sent more context to Robert in a DM, should have included it here:

I didn't implement prefetching in an operator in this first pass because it doesn't fit well into the upstream SegmentWriter abstraction & associated operators

codetheweb avatar Jan 02 '25 22:01 codetheweb

This stack of pull requests is managed by Graphite. Learn more about stacking.

codetheweb avatar Jan 13 '25 22:01 codetheweb

Barring any fallout from my question above this makes sense to me. Thanks for the attention to quality.

HammadB avatar Jan 23 '25 06:01 HammadB