chroma icon indicating copy to clipboard operation
chroma copied to clipboard

Add precommit hooks for black/flake. Global formatting PR

Open HammadB opened this issue 2 years ago • 5 comments

  1. Add precommit hooks
  2. Run global formatting.

HammadB avatar Apr 04 '23 18:04 HammadB

Let's do one big formatting-only PR as part of this.

atroyn avatar Apr 24 '23 18:04 atroyn

Hi there! I am interested in contributing to this project and would like to request permission to work on this issue. I have experience with the technologies involved and believe I can provide a useful contribution to the project. Please let me know if there are any specific guidelines or instructions I should follow when working on this issue. Thank you!

rodneyosodo avatar Apr 26 '23 17:04 rodneyosodo

That would be excellent if you want to! We basically want to integrate https://pre-commit.com/ to run flake8 and black on git commit. Then we want to use precommit run all files to to a global formatting pass. https://pre-commit.com/#4-optional-run-against-all-the-files

HammadB avatar Apr 26 '23 17:04 HammadB

I've assigned the issue to you @rodneyosodo - if you decide not to take this on let me know! Was planning on doing it later this week :) Thanks so much!

HammadB avatar Apr 26 '23 17:04 HammadB

Can we try ruff?

rodneyosodo avatar Apr 26 '23 20:04 rodneyosodo

Closed by #483

HammadB avatar May 09 '23 18:05 HammadB