chroma icon indicating copy to clipboard operation
chroma copied to clipboard

[ENH] Add segment configuration to distributed sysdb

Open HammadB opened this issue 1 year ago • 2 comments

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Update go readmes for migration
  • New functionality
    • Adds segment configuration to distributed sysdb by adding a new migration
    • Makes the rust codebase use configuration instead of metadata

Test plan

How are these changes tested?

  • I added a test in go dao tests for configuraton null and not null cases
  • Existing tests cover functionality
  • I added tests in rust for with configuration and with missing configuration
  • [x] Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

None

HammadB avatar Jul 31 '24 01:07 HammadB

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • [ ] Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • [ ] Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • [ ] If appropriate, are there adequate property based tests?
  • [ ] If appropriate, are there adequate unit tests?
  • [ ] Should any logging, debugging, tracing information be added or removed?
  • [ ] Are error messages user-friendly?
  • [ ] Have all documentation changes needed been made?
  • [ ] Have all non-obvious changes been commented?

System Compatibility

  • [ ] Are there any potential impacts on other parts of the system or backward compatibility?
  • [ ] Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • [ ] Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

github-actions[bot] avatar Jul 31 '24 01:07 github-actions[bot]

[!WARNING] This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite. Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

HammadB avatar Jul 31 '24 23:07 HammadB