chroma
chroma copied to clipboard
[ENH] generate IDs during .add() if not provided
Closes https://github.com/chroma-core/chroma/issues/2286.
Does not update the JS client since it's in the midst of a refactor.
Reviewer Checklist
Please leverage this checklist to ensure your code review is thorough before approving
Testing, Bugs, Errors, Logs, Documentation
- [ ] Can you think of any use case in which the code does not behave as intended? Have they been tested?
- [ ] Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
- [ ] If appropriate, are there adequate property based tests?
- [ ] If appropriate, are there adequate unit tests?
- [ ] Should any logging, debugging, tracing information be added or removed?
- [ ] Are error messages user-friendly?
- [ ] Have all documentation changes needed been made?
- [ ] Have all non-obvious changes been commented?
System Compatibility
- [ ] Are there any potential impacts on other parts of the system or backward compatibility?
- [ ] Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?
Quality
- [ ] Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)
Should we let a user give us IDs only sometimes, e.g. by allowing None in the ids list? My gut says no, but worth thinking about.
I don't think so, I can't think of a scenario where this would be helpful.
Superseded by https://github.com/chroma-core/chroma/pull/2699.