Christoph Rueger
Christoph Rueger
> I use Astrojs now. Can you elaborate a bit on your migration? What was the biggest effort / pain? How difficult was it to replace the GraphQL layer from...
Not entirely sure about `Bundle-SymbolicName` Do we want: a) `Bundle-SymbolicName: org.jspecify.jspecify` or b) `Bundle-SymbolicName: org.jspecify.annotations` a) is currently implemented. It is based on the maven artifact GAV (`org.jspecify:jspecify:jar:0.3.0` e.g. see...
@ben-manes thanks a lot for the pointers. I tried adding your suggestions about reproducible builds - although I must admit I have no experience with it, so could you double...
> lgtm (but just an observer) Thanks a lot.
@pkriens Do you have any thoughts? Would this be a useful feature? How would you go about the code re-use between `MbrCommand.java` and this class? I first thought about reusing...
Thanks for the feedback @pkriens I added some commits trying to share as much code as I could. One question about something I am not sure: In `calculateUpdateRevisions()` https://github.com/bndtools/bnd/pull/6104/files#diff-9798d76a25282bc3dff5647b6739f82970d66f20f02645d60e6bad8333fc1b91R86 I...
> We can use the logger for tracing etc. Maybe it should use Result for the methods instead of outputing information? In general you do not want to do any...
> Question: Is this an ok way to check for "updated" versions? > [2d1f949#diff-9bfdb19b4bf9085bd6f3d2c890803a16eb8b3fe79b3e4f923dd725e8c4cd1d1aR162-R166](https://github.com/bndtools/bnd/commit/2d1f949e649f724c2615145f7d013033b07bbd98#diff-9bfdb19b4bf9085bd6f3d2c890803a16eb8b3fe79b3e4f923dd725e8c4cd1d1aR162-R166) ~~Damn, I noticed I misunderstood the previous logging. I thought the previous logging only logged updated...
## Some notes about how to test bnd mbr from the cli - Download artifact from https://github.com/bndtools/bnd/actions/runs/8943851663/job/24569452716?pr=6104 e.g. https://github.com/bndtools/bnd/actions/runs/8943851663/artifacts/1471727005 and unzip it - unzip it to e.g. ~/Downloads/Dist_Bundles_JDK17_ubuntu-latest - go...
> LGTM, want to merge it? Yes