Chris Papademetrious

Results 177 comments of Chris Papademetrious
trafficstars

If I use [ditaot_save_preprocessing.pl](https://github.com/chrispy-snps/DITA-ditaot-utilities#using-ditaot_save_preprocessingpl) to look at the contents of `map.ditamap` going into the `keyref` preprocessing stage, the keyscoped peer mapref causing the issue is as follows: ``` Home My...

Thanks @raducoravu! I have corrected the testcase archive in-place.

With your change, the small `4007.zip` testcase above now gives the following: ``` keyref: [keyref] Reading file:/tmp/temp20220919082024727/map.ditamap Error: java.lang.NullPointerException: element cannot be mapped to a null key ``` but our...

For the following message: ``` keyref: [keyref] Reading file:/tmp/temp20220919090811619/map.ditamap Error: java.lang.NullPointerException: Cannot read field "keyDefinition" because "scope" is null ``` Here is a testcase: [4007-scope-is-null.zip](https://github.com/dita-ot/dita-ot/files/9599146/4007-scope-is-null.zip) It contains the following file...

@raducoravu - this fix works perfectly, in both `4007.zip` and `4007-scope-is-null.zip`, with one topic reference and two topic references, and in our production content! Thank you! I can submit a...

@raducoravu - I don't think I will be able to write a test for this. Do you want me to submit a pull request for the code change and see...

@raducoravu - this fix worked perfectly for me. On our help collection map of about 7k topics, it eliminated the expected 48 duplicate topics correctly. I also compared your fix...

@jason-fox - I suggest removing the `priority="-10"` from the last template, as it's not needed.

But I think the default template for `"*"` is taking precedence over the `priority="-10"` template, or at least that's the behavior I see when I test these templates in isolation...

@hongyung - can you attach a small testcase that reproduces the issue?