Chris Needham
Chris Needham
I have just pushed a branch that replace Browserify with Rollup: https://github.com/bbc/peaks.js/tree/rollup This shows the improvement in file size we get from using Rollup: | Bundle size | Minified size...
Thanks. I don't think Peaks should expose all the Konva objects, if we can avoid it. Next step here is to try out peerDependencies and fix the demo page. Not...
I have just pushed an update to the custom markers demo, which Is now built using Rollup. https://github.com/bbc/peaks.js/tree/konva-imports/demo/custom-markers This seems to work OK, but changing my [React example](https://github.com/chrisn/peaksjs-react-example) as per...
Thanks! Yes, deleting `node_modules` and reinstalling fixed it.
This is all now implemented and merged to `master`. Is there a recommended way to reference the UMD bundles peaks.js and peaks.min.js from package.json?
I found this: https://github.com/rollup/rollup/wiki/pkg.module, which agrees with you. Let's try it!
@adi518 I have a [demo app](https://github.com/chrisn/peaksjs-react-example) that uses Webpack to bundle Peaks.js as dependency. That project also depends on Konva.js, but there's no duplication. If I add waveform-data as a...
> Without the types field, TS will complain about missing types for this library, so not a good idea. It's also unrelated to the purpose of main and module. That...
By design, the canonical data format is the [binary .dat format](https://github.com/bbc/audiowaveform/blob/master/doc/DataFormat.md), and the JSON format was only intended for browsers lacking ArrayBuffer support for dealing with binary data. That said,...
Thank you for mentioning this. The warnings come from Konva, and related issues have been raised there: https://github.com/konvajs/konva/issues/260, https://github.com/konvajs/konva/issues/1382. In some cases Peaks.js does allow the page to scroll, this...