Chris Needham

Results 487 comments of Chris Needham

Thanks for the feedback, this is a good suggestion. To implement, we'd need to move to FreeType text rendering, rather than using libgd's built in fonts as we currently do....

This would be a welcome addition, but it's not something I've had time to work on yet. If anyone's interested in contributing, please let me know.

I haven't observed this issue myself yet. I wonder why those changes fix it, do we have non-integer values somewhere?

I think that the fraction values may originate from mousedown and mousemove events. I have just pushed a change that calls `Math.floor()` on those values, which hopefully fixes this issue.

Yes, I think you're right - although I haven't seen non-integer values on my Windows 10 laptop with 4K display. `window.devicePixelRatio` reports 2.25. Would you mind testing the change in...

I haven't been able to reproduce this locally, in Firefox or Chrome. Which OS and browser version are you using?

Thanks. I have no way to test this. Is it the case that `WaveformZoomview._frameOffset` is being set to a non-integer value? If so, what causes that to happen?

Thanks for the kind feedback! Peaks.js is currently designed to have the two waveform views you see in this [screenshot image](https://raw.githubusercontent.com/bbc/peaks.js/master/peaks.png). There are other projects out there that are closer...

Release 0.10.0 allows you to create a single waveform view. Please see https://github.com/bbc/peaks.js/blob/master/demo/overview-waveform.html for an example.

There is already a `zoomview.displaying` event that gives you the start and end time when the waveform view scrolls (either automatically or if the user drags the view). This is...