Chris Wendt

Results 48 comments of Chris Wendt
trafficstars

Including the range info would be convenient for parsing, but on the other hand redundant with the annotation. I haven't reported this upstream since parsing makes it work on existing...

@benjaminapetersen Why don't you think that's correct? `env DEBUG=protractor-video-reporter grunt...` works for me.

Here's how to move this PR to https://github.com/sourcegraph/sourcegraph/tree/master/packages/browser-extensions ``` cd browser-extensions git format-patch master --stdout > /tmp/patch cd ../sourcegraph cat /tmp/patch | git am -3 --directory=packages/browser-extensions/ # and fixup merge...

I see, the removal of node-sass-import-once breaks the CSS: ![image](https://user-images.githubusercontent.com/1387653/44314850-694e5100-a3d2-11e8-9f0c-0696b873143c.png) This shouldn't be a problem if/when we switch from SASS to some CSS-in-JS solution (e.g. aphrodite). Unless there's a way...

Is there any other way to organize SASS imports? If not, we'll have to wait for HardSource to provide an answer to https://github.com/mzgoddard/hard-source-webpack-plugin/issues/416

Here's how to move this PR to https://github.com/sourcegraph/sourcegraph/tree/master/packages/browser-extensions ``` cd browser-extensions git format-patch master --stdout > /tmp/patch cd ../sourcegraph cat /tmp/patch | git am -3 --directory=packages/browser-extensions/ # and fixup merge...

Here's how to move this PR to https://github.com/sourcegraph/sourcegraph/tree/master/packages/browser-extensions ``` cd browser-extensions git format-patch master --stdout > /tmp/patch cd ../sourcegraph cat /tmp/patch | git am -3 --directory=packages/browser-extensions/ # and fixup merge...

Here's how to move this PR to https://github.com/sourcegraph/sourcegraph/tree/master/packages/browser-extensions ``` cd browser-extensions git format-patch master --stdout > /tmp/patch cd ../sourcegraph cat /tmp/patch | git am -3 --directory=packages/browser-extensions/ # and fixup merge...

Here's how to move this PR to https://github.com/sourcegraph/sourcegraph/tree/master/packages/browser-extensions ``` cd browser-extensions git format-patch master --stdout > /tmp/patch cd ../sourcegraph cat /tmp/patch | git am -3 --directory=packages/browser-extensions/ # and fixup merge...

Here's how to move this PR to https://github.com/sourcegraph/sourcegraph/tree/master/packages/browser-extensions ``` cd browser-extensions git format-patch master --stdout > /tmp/patch cd ../sourcegraph cat /tmp/patch | git am -3 --directory=packages/browser-extensions/ # and fixup merge...