Chris Lu

Results 500 comments of Chris Lu

@danlsgiga env variable can change, but it can only be changed by current process, right? Other processes can not change the env variable value once current process is already started.

Current masters are using host+port as identifiers in raft consensus. This caused problem where a master must use previous IP+port after restarts, which in some cases, e.g., Nomad or server...

I just thought of that `weed server -options=option.file` can be used to reload the option.file content. Seems an easier way to implement. The only catch is that the master list...

can not reproduce. worked fine. ``` Alpine-Mongo$ docker run -it --name mongo -e MONGO_INITDB_ROOT_USERNAME="root-user" -e MONGO_INITDB_ROOT_PASSWORD="pass123" -p "27019:27017" -v /Users/chris/tmp/mm/db:/data/db mongo_alpine:1.1 2020-11-30T20:15:04.708+0000 I CONTROL [initandlisten] MongoDB starting : pid=1 port=27017...

Try it on Linux.

@kmlebedev thanks for the sharp eyes! Please always follow the issue template.

Prefer not to merge this. This duplicates with liveness checking via grpc connections. This is also different from pinging the raft server when they disconnect.

> Can you describe what you don't like more specifically? This duplicates with liveness checking via grpc connections.

> Are you fine with pinging after master receives delete event in OnPeerUpdate? that should be fine. Need to add a timeout for the ping operation.