asio icon indicating copy to clipboard operation
asio copied to clipboard

On MSVC, Qt "emit" macro is #undef

Open jcmonnin opened this issue 4 years ago • 2 comments
trafficstars

Commit 2d3a4c9fcdeeea48dc6974389b4c5167da9e34f7 introduces #push_macro and #undef to defend agaist Qt macros (emit, signal, slot) within the boost::asio headers. On gcc anc clang the macros are restored with a #pop_macro at the end of the header file, but this is missing on MSVC. Is this an oversight, or is this not working on MSVC? A quick test adding the missing #pop_macro seem to fix the compile issue introduced with boost 1.77.0 in my application that mixes boost::asio with Qt.

jcmonnin avatar Aug 24 '21 21:08 jcmonnin

@jcmonnin PR https://github.com/chriskohlhoff/asio/pull/892 Open

xavier2k6 avatar Aug 31 '21 22:08 xavier2k6

Please also add the pop_macro calls in the sectiom for the Intel Compilers.

hauihau avatar Jul 05 '22 07:07 hauihau