Chris Sewell

Results 1351 comments of Chris Sewell

In principle, these methods should no longer be required on the transport, but not needed for this PR: https://github.com/aiidateam/aiida-firecrest/blob/eb7f7518857794a99bae3568c74f0981b695dd79/aiida_firecrest/transport.py#L521-L533

Also, as a follow-up for the transport, here I moved the currently hard-coded `verdi computer test` logic onto the transport, since some tests are specific to a "bash-type" transport: https://github.com/chrisjsewell/aiida_core/blob/092bf00c327e213b3de3fc1650df54218a88df54/aiida/client/implementation.py#L74

Hmmm, tricky one. I'm not against it per se, but always a little wary of changing the behaviour of these dunder methods, that don't have an easy deprecation path and/or...

> But first I would like to establish if the majority think this should be the expected behavior. Fair, and my answer would be I don't know off-hand lol. Perhaps,...

> Here's another very simple idea for approaching the mutability of Computers and Codes that would solve the main use cases I have in mind: copy-on-edit you beat me to...

I just want to double-check this, since its a pretty significant change; in particular I know there are tools that build PDFs from these documents, and I want to check...

> I would have thought they would be using LaTeX Basically its a "light-weight" alternative to running the whole horrible latex toolchain lol (naturally with some tradeoffs)

cc @danwos and @ubmarco, maybe you want to have a quick check of this, in particular if it would affect: https://github.com/useblocks/sphinx-simplepdf/blob/3a37cce56e5c4c019959621853c7b92e10f8a4ad/sphinx_simplepdf/builders/simplepdf.py#L26

FYI, I think it makes sense in general, I just want to check whether it would affect anyone "relying" on the current HTML output. Was trying to track down where...

> Was trying to track down where the current behaviour was implemented yeh goes all the way back to its creation: https://github.com/sphinx-doc/sphinx/commit/744a519c9234910eacd638abed7c0a947344f464 so thats good, that it was not added...