chriseth comments

Results 265 comments of


                                            chriseth

Redefine struct getters to return their struct type, not a tuple of individual fields

The automatic getters were designed before structs in the ABI were even considered. Especially for arrays, getters as they currently are make sense in certain cases, so I'm a bit...

Reconsider operators on ContractType

Oh wow! I think this is a remnant of contracts being treated as addresses. If you want to compare contracts like that, I think it would be better to require...

Enable plain `assert()` in non-release builds in CI

Please check the performance. For boost multiprecision, it makes a huge difference if it is built in debug or release mode. I would not be surprised if they also use...

Enable plain `assert()` in non-release builds in CI

We should check some more computation-intensive examples. Most of our tests do not need a lot of computation on bigints, but for example the linear solver will.

block.coinbase should not be payable

It doesn't actually hurt anyone, so I would just schedule for 0.9

Disallow trailing slashes in imports

We should restrict both filenames (at the level of CompilerStack / StandardCompiler / CommandlineInterface) and import paths to not end in slashes and not being empty. I don't think we...

Disallow ``codecopy`` in pure functions (and check for other cases)

Isn't disallowing access to `msg.data` also part of this issue?

Disallow ``codecopy`` in pure functions (and check for other cases)

What about internal functions that have `calldata` parameters? Can they use inline assembly and thus calldataload to access their parameters?

Add .exists() and .iscontract() on to the address type

Would calling it `hasCode` help in any way?

Make source maps byte-offset based instead of opcode-offset

Maybe we could make it start with a certain string to tell which kind it is and we could also include a version number.