Christofer Dutz

So if there is no feeback on either options (willing to work on it yourself or that there's budget availalbe) I think I will close this issue with the answer...

Ok ... I managed to setup my Logix device with some arrays and indeed I think we need to put some work in here.

So when working on the optimizer I added test-cases for the situations I was implementing ... it sort of seems as if you didn't run the testsuites. If I switch...

Well... The test is the data from a real world use case... I can have a more detailed look, but I am quite sure you're not setting the right endianess....

@glcj could you please simply whip up a unit test like the one I created for my test case? I guess only this way will we be able to implement...

So ... Even if we ignore the test that I built for the setup of my colleagues, I still have failing tests: The ModbusTypAllDatatypesIT fails for the boolean register Also...

So ... having a more detailed look on your PR and the code you changed ... so in the ModbusOptimizer you removed the handling of the Coils and treat everything...

So I don't have the time to address this ... so if you ensure the test-suite is green, feel free to merge ... if things break for my colleagues (which...

What's the status on this one?

Have you had a look at this? https://github.com/apache/plc4x/blob/a7ab2cf08c8b06b44c0d1b7ff8b71813d6a4966b/plc4j/drivers/modbus/src/main/java/org/apache/plc4x/java/modbus/base/optimizer/ModbusOptimizer.java#L419 Ok ... reading up on your case ... I guess you did ... sorry.