Christofer Dutz

Results 361 comments of Christofer Dutz

Guess I'll have to fully review this next week (Currently travelling) ... also would I like to continue the discussion on the list on if my proposal even makes sense...

Hi, sorry for coming late to the party ... was insanely busy on my side and I just came back from a holiday break, going through the open Pull Requests....

In general, the changes look good, however you manually seem to have edited generated code, so the changes will get lost the next time the maven build is executed.

@sruehl what do you think? You want to migrate this manually or should we close and drop it?

Aaaaaa ... now I understand the isssue ... yeah ... I first thought this was related to the "Register 1 = address 0 on the wire" problem ... but yeah...

Sorry for the late response ... guess I'll have to dig into this one ...

A quick look at your code shows me, you're opening and closing the connection on every request. I would strongly suggest not to do that ... cause you're not only...

Closing for lack of activity.