Christian Schlotter
Christian Schlotter
/close seems not to be present anymore according to above triage link + switching dates.
I think a way forward would be to set both for some time and maybe deprecate setting the ExternalIP, maybe via a feature gate so we could go through normal...
Note: I plan to revive this in January :-)
Action plan: - [x] Merge PR which adds configuration file for all cases for kubetest - #2417 - [ ] Merge fix PR: - #2453 - [x] Create test-infra PR...
I still have to summarise how the state is. We have the periodics running, but they fail on some tests (which was somewhat expected): * https://testgrid.k8s.io/sig-cluster-lifecycle-cluster-api-provider-vsphere#periodic-e2e-exp-kk * https://testgrid.k8s.io/sig-cluster-lifecycle-cluster-api-provider-vsphere#periodic-e2e-exp-kk-alpha-features * https://testgrid.k8s.io/sig-cluster-lifecycle-cluster-api-provider-vsphere#periodic-e2e-exp-kk-serial...
There are two occurrences for the wrong label `capv.infrastucture.cluster.x-k8s.io/aggregate-to-manager`: 1. At the ClusterRole `manager-role` as label: https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/blob/main/config/base/manager_role_aggregation_patch.yaml#L6 2. At the Clusterrole `aggregated-manager-role` at `aggregationRule.clusterRoleSelectors[]matchLabels` https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/blob/main/config/rbac/aggregate_role.yaml#L8 To fix the issue we...
Before proceeding here with an implementation, I think we need consensus on if the alternative approach is okay (because it would be easier) or if we have to go down...
/remove-lifecycle stale @sbueringer / @fabriziopandini : I propose to take the safe path and: 1. for v1.11: add the additional label in both places (so v1.11 has both labels) 2....
/remove-lifecycle stale