choo icon indicating copy to clipboard operation
choo copied to clipboard

add CONTRIBUTING & CODE_OF_CONDUCT

Open yoshuawuyts opened this issue 8 years ago • 9 comments

Adds a contributing file, and code of conduct as per https://github.com/choojs/discuss/issues/5. Hope this good; please do give it a read. Thanks!

Todo

  • [ ] add more collaborators to the "people to contact" list
  • [ ] rework the labels to what we're using (e.g. https://github.com/yoshuawuyts/github-standard-labels)

yoshuawuyts avatar Oct 20 '17 16:10 yoshuawuyts

Should we have more than one maintainer listed I think in case there are issues with the maintainer listed?

I like the examples section since it helps clarify the course of action.

toddself avatar Oct 20 '17 16:10 toddself

what @toddself said! might also be helpful if you're away etc. i heard its good to have an un-even number in case you need to take a vote / reach consensus on an issue.

otherwise looks good! glad you decided to adopt the WeAllJs version!

lrlna avatar Oct 20 '17 18:10 lrlna

@lrlna @toddself can I pencil the both of you in then?

yoshuawuyts avatar Oct 20 '17 23:10 yoshuawuyts

yea, pencil me in!

On Sat, 21 Oct 2017 at 01:49 Yoshua Wuyts [email protected] wrote:

@lrlna https://github.com/lrlna @toddself https://github.com/toddself can I pencil the both of you in then?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/choojs/choo/pull/587#issuecomment-338346780, or mute the thread https://github.com/notifications/unsubscribe-auth/AHu3CPMM0rM7Fi79i0Cq5fp4gdmMabYjks5suTFzgaJpZM4QA7Fp .

lrlna avatar Oct 22 '17 14:10 lrlna

Hmmm, we never ended up merging this. Think the wording in this CoC is not ideal tbh.

Using contributor covenant might make a bit more sense for us? Better understood, and probably easier to follow. Example: https://github.com/choojs/bankai/blob/f7d988e0ab609a83a11f90389f0fa0765167b677/.github/CODE_OF_CONDUCT.md

yoshuawuyts avatar Feb 01 '18 09:02 yoshuawuyts

Why do you think the contributor covenant is better for this?

On Thu, Feb 1, 2018, 10:16 Yoshua Wuyts [email protected] wrote:

Hmmm, we never ended up merging this. Think the wording in this CoC is not ideal tbh.

Using contributor covenant might make a bit more sense for us? Better understood, and probably easier to follow. Example: https://github.com/choojs/bankai/blob/f7d988e0ab609a83a11f90389f0fa0765167b677/.github/CODE_OF_CONDUCT.md

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/choojs/choo/pull/587#issuecomment-362205080, or mute the thread https://github.com/notifications/unsubscribe-auth/AHu3CPaRDxHAkRc1QLwtOL5PcFd4wF_dks5tQYDwgaJpZM4QA7Fp .

lrlna avatar Feb 01 '18 09:02 lrlna

@lrlna I made a Frankenstein edited version of a different CoC. The Contributor Covenant is nice & to the point; good enough that people might actually read the thing.

yoshuawuyts avatar Feb 01 '18 11:02 yoshuawuyts

@yoshuawuyts gotcha!

lrlna avatar Feb 02 '18 07:02 lrlna

+1 for contributor covenant, it's well known, well documented, and versioned. Easy to link to in contributing docs or copy to a CODE_OF_CONDUCT.md file. That's what I've done in the past for other projects :)

ungoldman avatar Feb 23 '18 18:02 ungoldman