jira-api-restclient icon indicating copy to clipboard operation
jira-api-restclient copied to clipboard

Support avatarId key in IssueType, throw Exception if response is not a JSON

Open testfairy opened this issue 10 years ago • 2 comments
trafficstars

Recent changes in Atlassian broke jira-api-restclient.

  1. avatarId is now returned in issueTypes (jira-api-restclient threw Exception upon unrecognised key.)
  2. Accidentally using http://*.atlassian.net instead of https:// will redirect and use GET instead of POST.
  3. Using GET when POST is required would have returned an HTTP error, but CurlClient returned it as a string. Thus, Api.php failed to parse.

testfairy avatar Jan 12 '15 19:01 testfairy

avatarId is now returned in issueTypes (jira-api-restclient threw Exception upon unrecognised key.)

Solved as part of #50.

Accidentally using http://*.atlassian.net instead of https:// will redirect and use GET instead of POST.

That is not the problem, that API client needs to be solving. Also JIRA doesn't force you to use HTTPS.

Using GET when POST is required would have returned an HTTP error, but CurlClient returned it as a string. Thus, Api.php failed to parse.

That is not the problem, that API client needs to be solving. Whoever is using the library must supply valid input. Just guessing from the call result if it's failed or not isn't bulletproof solution.

@jpastoor , overall I think this PR needs to be closed.

aik099 avatar Feb 27 '16 08:02 aik099

Please rebase and solve conflicts.

aik099 avatar May 22 '16 09:05 aik099