winpty submodule

[cjfromthesea]

Why is the repository using a fork of winpty as its submodule? I made a change to the original winpty that would fix compilation on Windows for this module. Can we switch the submodule to use winpty?

[peters]

I've made some changes to winpty which has not been upstreamed to richard.

[cjfromthesea]

Okay, so since you merged the same pull request I made on your repo, we can always just update to your latest repo to fix the header problem. Still would be good if we could merge those changes upstream, though.

[tracker1]

Need to push a fixed version to npm, the submodule doesn't seem to be getting checked into npm, and is broken, or at least it seems to be.

[peters]

@cjfromthesea I'm really busy so if you push whatever you need to get stuff working i'll merge it :)

[cjfromthesea]

I think it's all good, you already merged it. Just need to update the submodule here and push to npm.

[zahmet]

Is this fixed? When it's fixed does it mean that I will be able to use pty on a windows machine?

Atm. I just get that pty.cc makes an Assertion failed at line 218.

I'm guessing that it simply doesn't work on windows due to the fork things being a linux/unix thing, but winpty sounds promising. Is this coming soon? or am I simply missing something else.

[ioquatix]

It would be awesome if pty.js supported Windows, we have problems in script-runner.. https://github.com/ioquatix/script-runner/issues/5

[Tyriar]

I managed to get rid of all modifications to winpty in my fork node-pty and upgrade to [email protected] (which fixes a host of issues), I'm just working through the last kinks now before publishing the next version, see https://github.com/rprichard/winpty/issues/96