Geoff Chirgwin

Results 13 comments of Geoff Chirgwin
trafficstars

This is implemented in pull request #1

@paulflo150 I've just merged some additional selection fixes from the `next` branch into `master` on [my fork](https://github.com/PortChaw/ngImgCrop), but square/circle selections remain a little buggy. These changes are also available on...

@paulflo150 Thanks for that fix. Looks reasonable. If you want to create a pull request on my fork, I'll gladly take a closer look and merge it. Or, I can...

@sanketsaurav The problem here is that the output image isn't being resized with the selection (see issue #4 and pull request #7). I've cherry-picked these changes from #7 into the...

As requested at least a couple of times in this thread, @sderungs has implemented arbitrary fixed aspect ratios for rectangular selections. Thanks for that. This is now merged into master...

@iceye I'll gladly merge your changes into my fork if you create a pull request. Ditto for other rectangle related changes. @alexk111 What iceye said; would love to see this...

Thanks, @alexk111. #1 should be ready to merge. @robianmcd Aspect ratio is covered by issue #17. See my comment about it there. Short answer is it will be lumped in...

@alexk111 Looks like this bug is related to adding support for getting pixel array data (commit b919ac94e5), which should've been a separate branch/pull request. My mistake for conflating this with...

> Why doesn't the result image have the same aspect ratio as the crop area? This requires getting the result dimensions-- covered separately in issue #4 and pull request #7--...

@alexk111 OK, I'll make some time for this soon. Please expect an update within 24 hours or so.