chisel
chisel copied to clipboard
Fix Select.attachedTo (backport #4458)
Previously it would always fail to find anything.
Working on the Mill build, I was lazy in setting up scalacOptions and applied -Xlint:infer-any to everything which caught this. Unfortuantely, Iterable.contains is not type safe but if you screw up the type, this lint will catch it inferring Any (or Object).
Contributor Checklist
- [ ] Did you add Scaladoc to every public function/method?
- [x] Did you add at least one test demonstrating the PR?
- [x] Did you delete any extraneous printlns/debugging code?
- [x] Did you specify the type of improvement?
- [x] Did you add appropriate documentation in
docs/src? - [x] Did you request a desired merge strategy?
- [ ] Did you add text to be included in the Release Notes for this change?
Type of Improvement
- Bugfix
Desired Merge Strategy
- Squash
Release Notes
Reviewer Checklist (only modified by reviewer)
- [ ] Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
- [ ] Did you mark the proper milestone (Bug fix:
3.6.x,5.x, or6.xdepending on impact, API modification or big change:7.0)? - [ ] Did you review?
- [ ] Did you check whether all relevant Contributor checkboxes have been checked?
- [ ] Did you do one of the following when ready to merge:
- [ ] Squash: You/ the contributor
Enable auto-merge (squash), clean up the commit message, and label withPlease Merge. - [ ] Merge: Ensure that contributor has cleaned up their commit history, then merge with
Create a merge commit.
- [ ] Squash: You/ the contributor
This is an automatic backport of pull request #4458 done by [Mergify](https://mergify.com).
Cherry-pick of 1aa41cdb7e7406c0aba3e9de3ebb06c3eb8c40d9 has failed:
On branch mergify/bp/3.6.x/pr-4458
Your branch is up to date with 'origin/3.6.x'.
You are currently cherry-picking commit 1aa41cdb7.
(fix conflicts and run "git cherry-pick --continue")
(use "git cherry-pick --skip" to skip this patch)
(use "git cherry-pick --abort" to cancel the cherry-pick operation)
Changes to be committed:
modified: src/test/scala/chiselTests/aop/SelectSpec.scala
Unmerged paths:
(use "git add <file>..." to mark resolution)
both modified: src/main/scala/chisel3/aop/Select.scala
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally