Ilya Shipitsin

I reported 3 issues because I first invoked `make -j3 ERR=1...` and it stopped after 3 detections

clang is in my queue as well On Thu, Dec 29, 2022, 4:08 PM Willy Tarreau ***@***.***> wrote: > Here it's not just some false positives, it's a totally bogus...

Thank you for the review, I'll check on master branch and report them to GCC. Hopefully, if we will contact them once an year, it will be working in 10...

> It seems that the double-free check isn't any better: > > ``` > src/namespace.c: In function 'netns_sig_stop': > src/namespace.c:55:17: error: double-'free' of '*(struct netns_entry *)node.node.key' [CWE-415] [-Werror=analyzer-double-fre] > 55...

couple of issues reported to gcc https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108251 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108252 closing this issue

I'm afraid structure should be renamed, please see https://github.com/skeeto/endlessh/issues/14 https://github.com/skeeto/endlessh/pull/17

it was marked as false positve.

i.e. coverity still thinks there's an issue, but it was muted

brief look at th PR gives me an idea that we leak something on l2tp client disconnect so, if I for example connect/disconnect many times, I'll see something bad, right...

please tell your steps. what you actually expected to get what did you actually get