Chip Hogg

Even though it looks like I shouldn't expect this to close any time soon, I'm still happy the issue is in the correct state. :slightly_smiling_face: Thanks!

Perhaps a good way to move this forward would be: - take one of Google's internal tests which this breaks - create a similar test in the public repo which...

Happy New Year 2025 to all of the various `EXPECT_NEAR` enthusiasts here! I'm moving the conversation here, because an open issue seems like a better home than a closed PR....

Here's a brand new idea! Given the modern guidance to [prefer `EXPECT_THAT` to other macros](https://www.linkedin.com/pulse/3-more-things-i-wish-had-done-differently-google-test-zhanyong-wan-rvi4c/), googletest should **introduce a new matcher, `IsNear(target, tolerance)`,** that has the correct behavior from the...

This is extremely encouraging --- thank you! That said, I think we're not quite there yet. See this [godbolt link](https://godbolt.org/z/37WMGEKT8). It turns out that `std::abs` doesn't make sense for quantity...

By the way: I love the other design change compared to `EXPECT_NEAR`, where we're using a _matcher_ instead of a simple numeric tolerance! 🤩

Thanks for keeping us in the loop on this issue! One thing that I would find instructive is an example of how this would cause a problem. I guess this...

Amazing! I'm excited to check back tomorrow and play with it once the godbolt link updates.

Confirmed: it simply works! As far as I'm concerned, this issue is now resolved, with a good outcome. Thank you!

Could you give a simple example to illustrate? I think the issue would read a lot better with an example.