Chinmay Garde

Results 283 comments of Chinmay Garde

LGTM but the regex for ICU still isn't quite right.

We saw these types of issues with the Skia backend at runtime in https://github.com/flutter/flutter/issues/68649#issuecomment-828750142 and that issue was closed after it stopped happening after a while. There was no resolution....

I highly recommend having the GN reference handy for this as that's what I am using throughout this reply. You can either access it online at https://gn.googlesource.com/gn/+/main/docs/reference.md or `gn help`...

Doesn't this need a fallback for ES2?

We think the `_AssetAutolayoutOnAllowedThreadsOnly` crash is unrelated and will be fixed by the patch to not interact with transactions on the background thread. We haven't seen the crash that attempts...

The failures do look related. Perhaps you missed a spot where the paths need a fixup?

Triage: Looks like we aren't going to move ahead with this. Closing. But please re-open if I am mistaken.

CI is running into https://github.com/flutter/flutter/issues/166845 repeatedly. Going to try again later.