cornerstone_widget icon indicating copy to clipboard operation
cornerstone_widget copied to clipboard

end-to-end testing

Open kmader opened this issue 7 years ago • 2 comments
trafficstars

based on the failed PR #9 the idea would be to have javascript style/testing to make sure the code is reasonable #1 and full end-to-end testing to make sure it actually works in a browser (Chrome ATM) running the notebook

kmader avatar Sep 24 '18 09:09 kmader

from @bollwyvl's post on the failed PR

geckodriver must be downloaded into path separately

If you're on the conda bus, you still have to install firefox and chrome yourself, but...

... are all conda-forged.

Here are some examples of testing Jupyter(Lab) with robot:

I keep meaning to capture all of these in a library, but continue to eat the copy-pasta.

kmader avatar Sep 24 '18 09:09 kmader

Sorry, didn't read your code enough:

Since you're already looking at jyve, make sure to add the browsers to Travis, a la:

addons:
    firefox: latest
    chrome: stable

Also, I'm not an imaging guy, but: there's also https://github.com/InsightSoftwareConsortium/itk-jupyter-widgets which is kind of mind blowing.

On Mon, Sep 24, 2018, 05:47 Kevin Mader [email protected] wrote:

from @bollwyvl https://github.com/bollwyvl's post on the failed PR

geckodriver must be downloaded into path separately

If you're on the conda bus, you still have to install firefox and chrome yourself, but...

... are all conda-forged.

Here are some examples of testing Jupyter(Lab) with robot:

I keep meaning to capture all of these in a library, but continue to eat the copy-pasta.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/chestrays/cornerstone_widget/issues/18#issuecomment-423923543, or mute the thread https://github.com/notifications/unsubscribe-auth/AACxRMilKEE-HPKs0RUTDzvRm8PVNkaRks5ueKofgaJpZM4W2V6m .

bollwyvl avatar Sep 24 '18 11:09 bollwyvl