checkpointctl icon indicating copy to clipboard operation
checkpointctl copied to clipboard

memparse: add search functionality to memparse

Open behouba opened this issue 1 year ago • 2 comments

This draft PR is intended to help evaluate the performance of #163. It introduces --search and --context flags to memparse, enabling pattern searches within a process's memory pages.

Example usage:

checkpointctl memparse --search=JAVA_VERSION --context=10 --pid 2 jira-chkpt.tar.gz

Address           Pattern                           Instance
------------------------------------------------------------
000000008181bf00    =       JAVA_VERSION            [1]
000000008181bf20    =       JAVA_VERSION            [2]
00007fffe4e28fc2  sian/jira JAVA_VERSION=jdk-11.0.  [3]

behouba avatar Jul 21 '24 02:07 behouba

Test Results

60 tests  +5   60 :white_check_mark: +5   1s :stopwatch: ±0s  1 suites ±0    0 :zzz: ±0   1 files   ±0    0 :x: ±0 

Results for commit be48b4a5. ± Comparison against base commit 037da263.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Jul 21 '24 02:07 github-actions[bot]

Codecov Report

Attention: Patch coverage is 90.90909% with 6 lines in your changes missing coverage. Please review.

Project coverage is 81.50%. Comparing base (f76433c) to head (be48b4a). Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
cmd/memparse.go 90.90% 3 Missing and 3 partials :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #141      +/-   ##
==========================================
+ Coverage   78.73%   81.50%   +2.77%     
==========================================
  Files          11       11              
  Lines        1260     1060     -200     
==========================================
- Hits          992      864     -128     
+ Misses        201      126      -75     
- Partials       67       70       +3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jul 25 '24 16:07 codecov-commenter

Hi @behouba! If you feel the changes on go-criu are ready, we can make a new release of the library and update this PR. What do you think?

snprajwal avatar Aug 27 '24 10:08 snprajwal

Hi @snprajwal! I think we’re ready for a new release of go-criu. I’ve been testing the new feature on various checkpoints, and everything seems to be working well so far. Let’s proceed with a new release of the library )

behouba avatar Aug 28 '24 10:08 behouba

@behouba we have go-criu v7.2.0 out :)

snprajwal avatar Sep 09 '24 09:09 snprajwal

@rst0git PTAL

snprajwal avatar Sep 23 '24 22:09 snprajwal